Code review comment for lp:~ris/unity-2d/fix-692444

Revision history for this message
Florian Boucault (fboucault) wrote :

Code in Trash::running() and Trash::show() is mostly duplicated. Code duplication could be avoided by creating a utility method that returns the first BamfWindow corresponding to the trash if it exists:

BamfWindow* firstWindow();

review: Needs Fixing (code)

« Back to merge proposal