Merge lp:~ris/ubuntu/natty/empathy/fix-681413 into lp:ubuntu/natty/empathy

Proposed by Robert Sajdok
Status: Needs review
Proposed branch: lp:~ris/ubuntu/natty/empathy/fix-681413
Merge into: lp:ubuntu/natty/empathy
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+6/-0)
src/empathy-main-window.c (+2/-1)
To merge this branch: bzr merge lp:~ris/ubuntu/natty/empathy/fix-681413
Reviewer Review Type Date Requested Status
Bilal Akhtar (community) Needs Fixing
Review via email: mp+43198@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Please add a debian/changelog message as well.

To do this, run:

dch -i

in a terminal and describe the changes you made there.

Oh, and, please ensure that these changes are made into a quilt patch. http://wiki.debian.org/UsingQuilt will help.

review: Needs Fixing
129. By Robert Sajdok

src/empathy-main-window.c fixed: add tooltip for error. (LP: #681413)

Revision history for this message
Robert Sajdok (ris) wrote :

On 12/10/10 at 10:09am, Bilal Akhtar wrote:
> Review: Needs Fixing
> Please add a debian/changelog message as well.
>
> To do this, run:
>
> dch -i
>
> in a terminal and describe the changes you made there.
>
> Oh, and, please ensure that these changes are made into a quilt patch. http://wiki.debian.org/UsingQuilt will help.

I did it this way:

$ dch -i
$ bzr diff
$ debcommit
$ bzr push lp:~ris/ubuntu/natty/empathy/fix-681413

Correct?

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

On 12/10/2010 03:13 PM, Robert Sajdok wrote:
> On 12/10/10 at 10:09am, Bilal Akhtar wrote:
>> Review: Needs Fixing
>> Please add a debian/changelog message as well.
>>
>> To do this, run:
>>
>> dch -i
>>
>> in a terminal and describe the changes you made there.
>>
>> Oh, and, please ensure that these changes are made into a quilt patch. http://wiki.debian.org/UsingQuilt will help.
>
> I did it this way:
>
> $ dch -i
> $ bzr diff
> $ debcommit
> $ bzr push lp:~ris/ubuntu/natty/empathy/fix-681413
>
> Correct?

yes

Unmerged revisions

129. By Robert Sajdok

src/empathy-main-window.c fixed: add tooltip for error. (LP: #681413)

128. By Robert Sajdok

Fix bug:
https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/681413

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-12-06 16:14:51 +0000
3+++ debian/changelog 2010-12-10 12:06:28 +0000
4@@ -1,3 +1,9 @@
5+empathy (2.32.2-0ubuntu3) lucid; urgency=low
6+
7+ * src/empathy-main-window.c fixed: add tooltip for error. (LP: #681413)
8+
9+ -- Robert Sajdok <robert.sajdok@gmail.com> Fri, 10 Dec 2010 12:52:47 +0100
10+
11 empathy (2.32.2-0ubuntu2) natty; urgency=low
12
13 * debian/patches/00git_folks_aliasable_groupable.patch:
14
15=== modified file 'src/empathy-main-window.c'
16--- src/empathy-main-window.c 2010-11-17 10:05:40 +0000
17+++ src/empathy-main-window.c 2010-12-10 12:06:28 +0000
18@@ -612,7 +612,8 @@
19 g_signal_connect (retry_button, "clicked",
20 G_CALLBACK (main_window_error_retry_clicked_cb),
21 window);
22-
23+
24+ gtk_widget_set_tooltip_text(priv->errors_vbox, error_message);
25 gtk_widget_show (priv->errors_vbox);
26
27 g_hash_table_insert (priv->errors, g_object_ref (account), info_bar);

Subscribers

People subscribed via source and target branches