Merge lp:~ris/loco-team-portal/part-fix-720824-meetings into lp:loco-team-portal

Proposed by Robert Sajdok
Status: Merged
Merged at revision: 552
Proposed branch: lp:~ris/loco-team-portal/part-fix-720824-meetings
Merge into: lp:loco-team-portal
Diff against target: 192 lines (+80/-32)
5 files modified
loco_directory/common/forms.py (+29/-0)
loco_directory/events/forms.py (+0/-31)
loco_directory/events/views.py (+1/-1)
loco_directory/meetings/views.py (+27/-0)
loco_directory/templates/meetings/meeting_history_list.html (+23/-0)
To merge this branch: bzr merge lp:~ris/loco-team-portal/part-fix-720824-meetings
Reviewer Review Type Date Requested Status
Adnane Belmadiaf Approve
Review via email: mp+114997@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Adnane Belmadiaf (daker) wrote :

Thanks Robert for the MP, i'll look into it in the next few days.

Revision history for this message
Adnane Belmadiaf (daker) wrote :

Thanks for the fix Robert, merged :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/common/forms.py'
2--- loco_directory/common/forms.py 2010-11-20 17:25:50 +0000
3+++ loco_directory/common/forms.py 2012-07-14 20:22:20 +0000
4@@ -2,6 +2,8 @@
5 from django import forms
6 from django.utils.translation import ugettext as _
7
8+import datetime
9+
10 # Taken from http://djangosnippets.org/snippets/1732/
11 class RenderableMixin(object):
12 """
13@@ -50,3 +52,30 @@
14 "Returns this form rendered. Only the fields. Nothing else HTML."
15 return self._html_output(u'%(label)s %(errors)s%(field)s%(help_text)s', u'%s', '', u'%s', False)
16
17+class FilterHistoryList(forms.Form):
18+ """
19+ a form to filter event history list
20+ """
21+
22+ choices = [('all', _(u'all')), ('my', _(u'month and year')), ('y', _(u'only year'))]
23+
24+ scope = forms.ChoiceField(choices)
25+
26+ now = datetime.datetime.now().strftime("%Y-%m")
27+ filtering = forms.CharField(required=False, initial=now)
28+
29+ class Media:
30+ css = {'all': (
31+ '/media/jquery-ui/css/css/smoothness/jquery-ui.css',
32+ '/media/jquery-ui-timepicker/css/ui-lightness/ui.timepickr.css',
33+ '/media/css/colortip-1.0-jquery.css',
34+ '/media/css/newstyle.css',
35+ )}
36+ js = (
37+ '/media/jquery/jquery.js',
38+ '/media/jquery-ui/jquery-ui.js',
39+ '/media/jquery-ui-timepicker/js/jquery.timepickr.min.js',
40+ '/media/jquery-ui-timepicker/js/ui.timepickr.min.js',
41+ '/media/js/colortip-1.0-jquery.js',
42+ '/media/js/events-ui.js',
43+ )
44
45=== modified file 'loco_directory/events/forms.py'
46--- loco_directory/events/forms.py 2012-06-30 23:44:14 +0000
47+++ loco_directory/events/forms.py 2012-07-14 20:22:20 +0000
48@@ -10,8 +10,6 @@
49 from userprofiles.models import UserProfile
50
51 import itertools
52-import datetime
53-
54
55 def grouped_user_list(teams):
56 other_members, team_members = [], []
57@@ -199,32 +197,3 @@
58 '/media/jquery/jquery.js',
59 '/media/js/colortip-1.0-jquery.js',
60 )
61-
62-
63-class FilterHistoryList(forms.Form):
64- """
65- a form to filter event history list
66- """
67-
68- choices = [('all', _(u'all')), ('my', _(u'month and year')), ('y', _(u'only year'))]
69-
70- scope = forms.ChoiceField(choices)
71-
72- now = datetime.datetime.now().strftime("%Y-%m")
73- filtering = forms.CharField(required=False, initial=now)
74-
75- class Media:
76- css = {'all': (
77- '/media/jquery-ui/css/css/smoothness/jquery-ui.css',
78- '/media/jquery-ui-timepicker/css/ui-lightness/ui.timepickr.css',
79- '/media/css/colortip-1.0-jquery.css',
80- '/media/css/newstyle.css',
81- )}
82- js = (
83- '/media/jquery/jquery.js',
84- '/media/jquery-ui/jquery-ui.js',
85- '/media/jquery-ui-timepicker/js/jquery.timepickr.min.js',
86- '/media/jquery-ui-timepicker/js/ui.timepickr.min.js',
87- '/media/js/colortip-1.0-jquery.js',
88- '/media/js/events-ui.js',
89- )
90
91=== modified file 'loco_directory/events/views.py'
92--- loco_directory/events/views.py 2012-06-30 23:44:14 +0000
93+++ loco_directory/events/views.py 2012-07-14 20:22:20 +0000
94@@ -16,9 +16,9 @@
95 from forms import TeamEventCommentForm
96 from forms import GlobalEventForm
97 from forms import AttendeeRegistrationForm
98-from forms import FilterHistoryList
99
100 from common.utils import redirect, simple_iterator
101+from common.forms import FilterHistoryList
102 from common import launchpad
103
104 import datetime
105
106=== modified file 'loco_directory/meetings/views.py'
107--- loco_directory/meetings/views.py 2011-03-18 13:37:13 +0000
108+++ loco_directory/meetings/views.py 2012-07-14 20:22:20 +0000
109@@ -10,10 +10,12 @@
110 from teams.models import Team
111
112 from forms import TeamMeetingForm, AgendaItemForm
113+
114 from django.db.models import Q
115
116 from common.utils import redirect, simple_iterator
117 from common import launchpad
118+from common.forms import FilterHistoryList
119
120 from userprofiles.models import UserProfile
121 import datetime
122@@ -78,7 +80,32 @@
123 a list with all historical meetings (teammeetings)
124 """
125 team_meeting_list = TeamMeeting.objects.history_meetings()
126+
127+ if request.method == 'POST':
128+ form = FilterHistoryList(request.POST)
129+ if form.is_valid():
130+
131+ filtering = form.cleaned_data['filtering']
132+
133+ scope = form.cleaned_data['scope']
134+
135+ if u'my' in scope:
136+ filtering_date = datetime.datetime.strptime(filtering, "%Y-%m")
137+
138+ team_meeting_list = TeamMeeting.objects.history_meetings().filter(date_begin__year=filtering_date.year, date_begin__month=filtering_date.month)
139+ elif u'y' in scope:
140+ filtering_date = datetime.datetime.strptime(filtering, "%Y-%m")
141+
142+ team_meeting_list = TeamMeeting.objects.history_meetings().filter(date_begin__year=filtering_date.year)
143+ else:
144+ team_meeting_list = TeamMeeting.objects.history_meetings()
145+
146+ else:
147+ form = FilterHistoryList()
148+ team_meeting_list = TeamMeeting.objects.history_meetings()
149+
150 context = {
151+ 'form': form,
152 'team_meeting_list': team_meeting_list,
153 }
154 return render_to_response('meetings/meeting_history_list.html', context,
155
156=== modified file 'loco_directory/templates/meetings/meeting_history_list.html'
157--- loco_directory/templates/meetings/meeting_history_list.html 2012-06-02 11:50:27 +0000
158+++ loco_directory/templates/meetings/meeting_history_list.html 2012-07-14 20:22:20 +0000
159@@ -1,4 +1,9 @@
160 {% extends "base.html" %}
161+
162+{% block extrahead %}{{ block.super }}
163+ {{form.media}}
164+{% endblock %}
165+
166 {% load i18n %}
167
168 {% block page_name %}{% trans "Ubuntu Teams Meeting History" %}{% endblock %}
169@@ -11,6 +16,24 @@
170 <div class="row">
171 <section class="span-12">
172 <h2>{% trans "Ubuntu Teams Meeting History" %}</h2>
173+
174+<form action="." method="post">{% csrf_token %}
175+<table class="table left">
176+<tr>
177+{% for field in form %}
178+ <td>
179+ {{ field }} {{ field.errors }}
180+ </td>
181+{% endfor %}
182+<td>
183+<input type="submit" value="Submit" />
184+</td>
185+</tr>
186+</table>
187+
188+</form>
189+</br>
190+
191 {% if team_meeting_list %}
192 <p>{% trans "Select a past team meeting below to see more information about it:" %}</p>
193

Subscribers

People subscribed via source and target branches