Merge lp:~ricsipontaz/day-scope/day-scope into lp:day-scope

Proposed by Richard Somlói on 2015-08-25
Status: Needs review
Proposed branch: lp:~ricsipontaz/day-scope/day-scope
Merge into: lp:day-scope
Diff against target: 13 lines (+2/-1)
1 file modified
src/query.cpp (+2/-1)
To merge this branch: bzr merge lp:~ricsipontaz/day-scope/day-scope
Reviewer Review Type Date Requested Status
day-scope-team 2015-08-25 Pending
Review via email: mp+269030@code.launchpad.net

Description of the change

Hi! In some languages (for example in Hungarian) the week number is before the week.

Example:

English: Week 34
Hungarian: 34. hét

But in the actual form I can't translate the string in this way. So I try to make it more flexible, but I'm not sure I did it in the right way, so please test it first. :) Thanks.

To post a comment you must log in.

Unmerged revisions

29. By Richard Somlói on 2015-08-25

More flexible localization of the Week number string.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/query.cpp'
2--- src/query.cpp 2015-08-06 06:01:34 +0000
3+++ src/query.cpp 2015-08-25 10:16:17 +0000
4@@ -249,7 +249,8 @@
5 day = day.replace(0,1,day[0].toUpper());
6 QString title = QString("%1, %2").arg(mo, day);
7 date_res.set_title(strong(title).toStdString());
8- QString week_no = QString("%1 %2").arg(QString::fromStdString(_("Week"))).arg(today.weekNumber());
9+ // TRANSLATORS: %1 is the actual week number
10+ QString week_no = QString::fromStdString(_("%1 Week")).arg(today.weekNumber());
11
12 string icon_path =
13 QString("%1/images/calendar-app_day-%2.png").arg(QString::fromStdString(scope_.scope_directory())).arg(today.toString("dd")).toStdString();

Subscribers

People subscribed via source and target branches