Merge lp:~ricotz/midori/format-security into lp:midori

[Rico Tzschichholz]

Fix warnings for -Wformat-security

Fix warnings for -Wformat-security

[Cody Garver (codygarver)]

https://fedoraproject.org/wiki/Format-Security-FAQ#How_do_I_fix_these_errors.3F

review: Approve

[Cris Dywan (kalikiana)]

We should look into getting these warnings as errors on our builds, or see if Vala has any way to warn about it.

The change itself is obviously correct.

review: Approve

=== modified file 'extensions/external-download-manager.vala'
--- extensions/external-download-manager.vala	2015-03-18 21:18:11 +0000
+++ extensions/external-download-manager.vala	2015-08-20 06:30:54 +0000
@@ -169,6 +169,7 @@
             if (message.status_code != 200) {
                 var dialog = new Gtk.MessageDialog (null, Gtk.DialogFlags.MODAL,
                     Gtk.MessageType.ERROR, Gtk.ButtonsType.CLOSE,
+                    "%s",
                     _("The plug-in was unable to connect with aria2:\n" +
                       "Please make sure that aria2 is running with rpc enabled ie: aria2c --enable-rpc\n" +
                       "If it's so, check it also is using the port 6800.\n" +

=== modified file 'extensions/transfers.vala'
--- extensions/transfers.vala	2014-04-23 05:40:37 +0000
+++ extensions/transfers.vala	2015-08-20 06:30:54 +0000
@@ -511,6 +511,7 @@
                 var dialog = new Gtk.MessageDialog (browser,
                     Gtk.DialogFlags.DESTROY_WITH_PARENT,
                     Gtk.MessageType.WARNING, Gtk.ButtonsType.NONE,
+                    "%s",
                     _("Some files are being downloaded"));
                 dialog.title = _("Some files are being downloaded");
                 dialog.add_buttons (Gtk.STOCK_CANCEL, Gtk.ResponseType.CANCEL,