Merge lp:~ricmm/ubuntu-app-launch/signal-start-on-started into lp:ubuntu-app-launch/13.10

[Ricardo Mendoza]

Currently we are signalling observers that app started on the "starting" signal. This is racy, as the final exec might not have happened yet, so if a client tries to get the primary PID before the process has fully started, it might get one of the transitional PIDs of the scripts that run in between.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:78
http://jenkins.qa.ubuntu.com/job/upstart-app-launch-ci/141/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-saucy-amd64-ci/143
    SUCCESS: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-saucy-armhf-ci/142
    SUCCESS: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-saucy-i386-ci/141

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/upstart-app-launch-ci/141/rebuild

review: Approve (continuous-integration)

[Charles Kerr (charlesk)]

Looks right to me.

review: Approve

[Gerry Boland (gerboland)]

Works for me

review: Approve

=== modified file 'libupstart-app-launch/upstart-app-launch.c'
--- libupstart-app-launch/upstart-app-launch.c	2013-09-26 21:48:27 +0000
+++ libupstart-app-launch/upstart-app-launch.c	2013-10-11 16:13:41 +0000
@@ -338,7 +338,7 @@
 gboolean
 upstart_app_launch_observer_add_app_start (upstart_app_launch_app_observer_t observer, gpointer user_data)
 {
-	return add_app_generic(observer, user_data, "starting", &start_array);
+	return add_app_generic(observer, user_data, "started", &start_array);
 }
 
 gboolean