Merge lp:~ricmm/qtubuntu/media-keys into lp:qtubuntu

Proposed by Ricardo Mendoza
Status: Work in progress
Proposed branch: lp:~ricmm/qtubuntu/media-keys
Merge into: lp:qtubuntu
Diff against target: 37 lines (+10/-3)
1 file modified
src/ubuntumirclient/input.cpp (+10/-3)
To merge this branch: bzr merge lp:~ricmm/qtubuntu/media-keys
Reviewer Review Type Date Requested Status
Gerry Boland (community) Needs Fixing
PS Jenkins bot continuous-integration Approve
Review via email: mp+236578@code.launchpad.net

Commit message

Extra keys

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~ricmm/qtubuntu/media-keys updated
246. By Ricardo Mendoza

Build debug

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~ricmm/qtubuntu/media-keys updated
247. By Ricardo Mendoza

Print

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

This been sitting here a while. Am happy to approve the added keys, but you've other debug lines changed

review: Needs Fixing

Unmerged revisions

247. By Ricardo Mendoza

Print

246. By Ricardo Mendoza

Build debug

245. By Ricardo Mendoza

Extra mappings for media controls

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntumirclient/input.cpp'
2--- src/ubuntumirclient/input.cpp 2014-09-02 10:34:47 +0000
3+++ src/ubuntumirclient/input.cpp 2014-10-01 13:44:58 +0000
4@@ -119,6 +119,13 @@
5 XKB_KEY_XF86PowerOff, Qt::Key_PowerOff,
6 XKB_KEY_XF86PowerDown, Qt::Key_PowerDown,
7
8+ XKB_KEY_XF86AudioMute, Qt::Key_VolumeMute,
9+ XKB_KEY_XF86AudioPrev, Qt::Key_MediaPrevious,
10+ XKB_KEY_XF86AudioNext, Qt::Key_MediaNext,
11+ XKB_KEY_XF86AudioPlay, Qt::Key_MediaPlay,
12+ XKB_KEY_XF86AudioStop, Qt::Key_MediaStop,
13+ XKB_KEY_XF86AudioPause, Qt::Key_MediaPause,
14+
15 0, 0
16 };
17
18@@ -370,16 +377,16 @@
19 {
20 const WindowEvent* event = reinterpret_cast<const WindowEvent*>(ev);
21
22- #if (LOG_EVENTS != 0)
23+// #if (LOG_EVENTS != 0)
24 // Key event logging.
25- LOG("KEY device_id:%d source_id:%d action:%d flags:%d meta_state:%d key_code:%d "
26+ fprintf(stderr, "KEY device_id:%d source_id:%d action:%d flags:%d meta_state:%d key_code:%d "
27 "scan_code:%d repeat_count:%d down_time:%lld event_time:%lld is_system_key:%d",
28 event->key.device_id, event->key.source_id,
29 event->key.action, event->key.flags, event->key.meta_state,
30 event->key.key_code, event->key.scan_code,
31 event->key.repeat_count, event->key.down_time,
32 event->key.event_time, event->key.is_system_key);
33- #endif
34+// #endif
35
36 ulong timestamp = event->key.event_time / 1000000;
37 xkb_keysym_t xk_sym = (xkb_keysym_t)event->key.key_code;

Subscribers

People subscribed via source and target branches