Merge lp:~ricmm/qtubuntu/build-multiple-binary-fix into lp:qtubuntu

Proposed by Ricardo Mendoza
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 203
Merged at revision: 202
Proposed branch: lp:~ricmm/qtubuntu/build-multiple-binary-fix
Merge into: lp:qtubuntu
Diff against target: 58 lines (+27/-7)
2 files modified
debian/rules (+23/-6)
src/modules/application/application.pro (+4/-1)
To merge this branch: bzr merge lp:~ricmm/qtubuntu/build-multiple-binary-fix
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+203975@code.launchpad.net

Commit message

Clean up build rules to allow for correct building of multiple binary packages from the same source.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
203. By Ricardo Mendoza

Split installation sets so that we can pull non-object files from the base source.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Good, tested with SF and it works again.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/rules' (properties changed: +x to -x)
2--- debian/rules 2013-12-09 17:31:20 +0000
3+++ debian/rules 2014-01-30 14:58:00 +0000
4@@ -5,16 +5,33 @@
5
6 ANDROID_DIR = build-android
7 DESKTOP_DIR = build-desktop
8+TMP1_DIR = $(CURDIR)/debian/tmp1
9+TMP2_DIR = $(CURDIR)/debian/tmp2
10
11 %:
12- dh $@ --builddirectory=$(ANDROID_DIR) --parallel
13- dh $@ --builddirectory=$(DESKTOP_DIR) --parallel
14+ dh $@
15+
16+override_dh_clean:
17+ rm -rf $(TMP1_DIR)
18+ rm -rf $(TMP2_DIR)
19+ dh_clean
20
21 override_dh_auto_configure:
22- mkdir -p $(ANDROID_DIR) && dh_auto_configure -- "CONFIG+=mirserver" "CONFIG+=mirclient" "CONFIG+=hybris" "QMAKE_CXXFLAGS=-g" $(CURDIR)
23- mkdir -p $(DESKTOP_DIR) && dh_auto_configure -- "CONFIG+=mirserver" "CONFIG+=mirclient" "QMAKE_CXXFLAGS=-g" $(CURDIR)
24+ mkdir -p $(ANDROID_DIR) && dh_auto_configure -B$(ANDROID_DIR) -- "CONFIG+=mirserver" "CONFIG+=mirclient" "CONFIG+=hybris" "QMAKE_CXXFLAGS=-g" $(CURDIR)
25+ mkdir -p $(DESKTOP_DIR) && dh_auto_configure -B$(DESKTOP_DIR) -- "CONFIG+=mirserver" "CONFIG+=mirclient" "QMAKE_CXXFLAGS=-g" $(CURDIR)
26+
27+override_dh_auto_build:
28+ dh_auto_build -B$(ANDROID_DIR)
29+ dh_auto_build -B$(DESKTOP_DIR)
30+
31+override_dh_auto_install:
32+ rm -f debian/*/usr/lib/*/qt5/examples/qtubuntu/qmlscene-ubuntu
33+ mkdir -p $(TMP1_DIR) && cd $(ANDROID_DIR) && INSTALL_ROOT=$(TMP1_DIR) make install
34+ cd $(CURDIR)
35+ mkdir -p $(TMP2_DIR) && cd $(DESKTOP_DIR) && INSTALL_ROOT=$(TMP2_DIR) make install
36+ cd $(CURDIR)
37
38 override_dh_install:
39- rm -f debian/*/usr/lib/*/qt5/examples/qtubuntu/qmlscene-ubuntu
40- dh_install --fail-missing
41+ dh_install --sourcedir=$(TMP1_DIR) -pqtubuntu-android
42+ dh_install --sourcedir=$(TMP2_DIR) -pqtubuntu-desktop
43
44
45=== modified file 'src/modules/application/application.pro'
46--- src/modules/application/application.pro 2013-11-22 15:24:44 +0000
47+++ src/modules/application/application.pro 2014-01-30 14:58:00 +0000
48@@ -37,6 +37,9 @@
49
50 LIBS += -lubuntu_application_api
51
52-target.files += libunityapplicationplugin.so qmldir OSKController.qml
53 target.path += $$[QT_INSTALL_IMPORTS]/Unity/Application
54 INSTALLS += target
55+
56+assets.files = qmldir OSKController.qml
57+assets.path = $$[QT_INSTALL_IMPORTS]/Unity/Application
58+INSTALLS += assets

Subscribers

People subscribed via source and target branches