Merge lp:~ricmm/platform-api/fix-crasher-on-last-app-dead into lp:platform-api

Proposed by Ricardo Mendoza
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 95
Merged at revision: 95
Proposed branch: lp:~ricmm/platform-api/fix-crasher-on-last-app-dead
Merge into: lp:platform-api
Diff against target: 12 lines (+1/-1)
1 file modified
android/hybris/default_application_manager.cpp (+1/-1)
To merge this branch: bzr merge lp:~ricmm/platform-api/fix-crasher-on-last-app-dead
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ricardo Salveti (community) Approve
Michał Sawicz functional Approve
Review via email: mp+175667@code.launchpad.net

Commit message

Stop changing focus when the binder that died was the last app in our list

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

Yes, this fixes the issue!

review: Approve (functional)
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Nice diff :)

How is this tested?

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'android/hybris/default_application_manager.cpp'
2--- android/hybris/default_application_manager.cpp 2013-07-02 21:22:36 +0000
3+++ android/hybris/default_application_manager.cpp 2013-07-18 19:52:32 +0000
4@@ -397,7 +397,7 @@
5 next_focused_app = main_stage_application;
6
7 ALOGI("%s():%d\n", __PRETTY_FUNCTION__, __LINE__);
8- if (i == focused_application)
9+ if (i && i == focused_application)
10 switch_focused_application_locked(next_focused_app);
11 else if(focused_application > i)
12 focused_application--;

Subscribers

People subscribed via source and target branches