Merge ~rickwu4444/plainbox-provider-certification-client:Add-tb3-to-IOT-and-ODM-UC18-and-20 into plainbox-provider-certification-client:master

Proposed by Rick Wu
Status: Merged
Approved by: Jonathan Cave
Approved revision: fb1fb8e9f5f164af2de546adfc6235ce50487de5
Merged at revision: 197a9321639920afe05745276eab360c3b42dcfe
Proposed branch: ~rickwu4444/plainbox-provider-certification-client:Add-tb3-to-IOT-and-ODM-UC18-and-20
Merge into: plainbox-provider-certification-client:master
Diff against target: 112 lines (+12/-0)
4 files modified
units/client-cert-iot-ubuntucore-18.pxu (+3/-0)
units/client-cert-iot-ubuntucore-20.pxu (+3/-0)
units/client-cert-odm-ubuntucore-18.pxu (+3/-0)
units/client-cert-odm-ubuntucore-20.pxu (+3/-0)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Jonathan Cave (community) Approve
Kristin Chuang (community) Approve
Sylvain Pineau Pending
Review via email: mp+401267@code.launchpad.net

Commit message

Add thunderbolt test into IOT and ODM UC18/20 whitelist

Description of the change

According to Certified Hardware Coverage for Ubuntu Core 18[1] and 20[2]. Add thunderbolt test into whitelist.
[1]http://certification-static.canonical.com/docs/UC18Coverage.pdf
[2]http://certification-static.canonical.com/docs/UC20Coverage.pdf

To post a comment you must log in.
Revision history for this message
Kristin Chuang (kristinchuang) wrote :

+1

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks, I note relevant documentation will be need to be updated to indicate that a Thunderbolt HDD needs to available for testing

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [11:06:45] starting container
Device project added to xenial-testing
[bionic] [11:06:46] starting container
[focal] [11:06:48] starting container
Device project added to bionic-testing
Device project added to focal-testing
[xenial] [11:06:58] provisioning container
[focal] [11:07:06] provisioning container
[bionic] [11:07:07] provisioning container
[xenial] [11:07:09] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-certification-client
[bionic] [11:07:21] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-certification-client
[focal] [11:07:21] Starting tests...
[focal] Found a test script: ./requirements/container-tests-provider-certification-client
[focal] [11:08:18] container-tests-provider-certification-client: PASS
[focal] [11:08:18] Fixing file permissions in source directory
[focal] [11:08:18] Destroying container
[xenial] [11:08:19] container-tests-provider-certification-client: FAIL
[bionic] [11:08:21] container-tests-provider-certification-client: PASS
[bionic] [11:08:21] Fixing file permissions in source directory
[bionic] [11:08:21] Destroying container
[xenial] output: https://paste.ubuntu.com/p/4BHMx2GHfm/
[xenial] [11:08:23] Fixing file permissions in source directory
[xenial] [11:08:23] Destroying container

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/units/client-cert-iot-ubuntucore-18.pxu b/units/client-cert-iot-ubuntucore-18.pxu
index 82f6875..de5b962 100644
--- a/units/client-cert-iot-ubuntucore-18.pxu
+++ b/units/client-cert-iot-ubuntucore-18.pxu
@@ -66,6 +66,7 @@ nested_part:
66 usb-manual66 usb-manual
67 usb-c-manual67 usb-c-manual
68 usb3-manual68 usb3-manual
69 thunderbolt-cert-manual
69 watchdog-manual70 watchdog-manual
70 wireless-manual71 wireless-manual
71 wireless-wifi-master-mode-manual72 wireless-wifi-master-mode-manual
@@ -81,6 +82,7 @@ nested_part:
81 after-suspend-usb-manual82 after-suspend-usb-manual
82 after-suspend-usb-c-manual83 after-suspend-usb-c-manual
83 after-suspend-usb3-manual84 after-suspend-usb3-manual
85 after-suspend-thunderbolt-cert-manual
84 after-suspend-wireless-manual86 after-suspend-wireless-manual
85 after-suspend-wireless-wifi-master-mode-manual87 after-suspend-wireless-wifi-master-mode-manual
86 after-suspend-wwan-manual88 after-suspend-wwan-manual
@@ -149,6 +151,7 @@ nested_part:
149 socketcan-auto-remote151 socketcan-auto-remote
150 tpm2.0_3.0.4-automated152 tpm2.0_3.0.4-automated
151 usb-automated153 usb-automated
154 thunderbolt-cert-automated
152 watchdog-automated155 watchdog-automated
153 wireless-automated156 wireless-automated
154 wireless-wifi-master-mode-auto157 wireless-wifi-master-mode-auto
diff --git a/units/client-cert-iot-ubuntucore-20.pxu b/units/client-cert-iot-ubuntucore-20.pxu
index a270dfc..3b4c878 100644
--- a/units/client-cert-iot-ubuntucore-20.pxu
+++ b/units/client-cert-iot-ubuntucore-20.pxu
@@ -67,6 +67,7 @@ nested_part:
67 usb-manual67 usb-manual
68 usb-c-manual68 usb-c-manual
69 usb3-manual69 usb3-manual
70 thunderbolt-cert-manual
70 watchdog-manual71 watchdog-manual
71 wireless-manual72 wireless-manual
72 wireless-wifi-master-mode-manual73 wireless-wifi-master-mode-manual
@@ -82,6 +83,7 @@ nested_part:
82 after-suspend-usb-manual83 after-suspend-usb-manual
83 after-suspend-usb-c-manual84 after-suspend-usb-c-manual
84 after-suspend-usb3-manual85 after-suspend-usb3-manual
86 after-suspend-thunderbolt-cert-manual
85 after-suspend-wireless-manual87 after-suspend-wireless-manual
86 after-suspend-wireless-wifi-master-mode-manual88 after-suspend-wireless-wifi-master-mode-manual
87 after-suspend-wwan-manual89 after-suspend-wwan-manual
@@ -151,6 +153,7 @@ nested_part:
151 socketcan-auto-remote153 socketcan-auto-remote
152 tpm2.0_4.1.1-automated154 tpm2.0_4.1.1-automated
153 usb-automated155 usb-automated
156 thunderbolt-cert-automated
154 watchdog-automated157 watchdog-automated
155 wireless-automated158 wireless-automated
156 wireless-wifi-master-mode-auto159 wireless-wifi-master-mode-auto
diff --git a/units/client-cert-odm-ubuntucore-18.pxu b/units/client-cert-odm-ubuntucore-18.pxu
index 702bd09..336342a 100644
--- a/units/client-cert-odm-ubuntucore-18.pxu
+++ b/units/client-cert-odm-ubuntucore-18.pxu
@@ -46,6 +46,7 @@ nested_part:
46 usb-c-manual46 usb-c-manual
47 usb-manual47 usb-manual
48 usb3-manual48 usb3-manual
49 thunderbolt-cert-manual
49 wwan-manual50 wwan-manual
50 i2c-manual51 i2c-manual
51 suspend-tp52 suspend-tp
@@ -53,6 +54,7 @@ nested_part:
53 after-suspend-bluetooth-manual54 after-suspend-bluetooth-manual
54 after-suspend-ethernet-manual55 after-suspend-ethernet-manual
55 after-suspend-wwan-manual56 after-suspend-wwan-manual
57 after-suspend-thunderbolt-cert-manual
56exclude:58exclude:
57 com.intel.ipdt::ipdt/PCH-.*59 com.intel.ipdt::ipdt/PCH-.*
58 usb-c/c-to-a-adapter.*60 usb-c/c-to-a-adapter.*
@@ -110,6 +112,7 @@ nested_part:
110 usb-c-automated112 usb-c-automated
111 usb-automated113 usb-automated
112 usb3-automated114 usb3-automated
115 thunderbolt-cert-automated
113 watchdog-automated116 watchdog-automated
114 wwan-automated117 wwan-automated
115 com.intel.ipdt::ipdt-plan118 com.intel.ipdt::ipdt-plan
diff --git a/units/client-cert-odm-ubuntucore-20.pxu b/units/client-cert-odm-ubuntucore-20.pxu
index b70ca1f..981a819 100644
--- a/units/client-cert-odm-ubuntucore-20.pxu
+++ b/units/client-cert-odm-ubuntucore-20.pxu
@@ -46,6 +46,7 @@ nested_part:
46 usb-c-manual46 usb-c-manual
47 usb-manual47 usb-manual
48 usb3-manual48 usb3-manual
49 thunderbolt-cert-manual
49 wwan-manual50 wwan-manual
50 i2c-manual51 i2c-manual
51 suspend-tp52 suspend-tp
@@ -53,6 +54,7 @@ nested_part:
53 after-suspend-bluetooth-manual54 after-suspend-bluetooth-manual
54 after-suspend-ethernet-manual55 after-suspend-ethernet-manual
55 after-suspend-wwan-manual56 after-suspend-wwan-manual
57 after-suspend-thunderbolt-cert-manual
56exclude:58exclude:
57 com.intel.ipdt::ipdt/PCH-.*59 com.intel.ipdt::ipdt/PCH-.*
58 usb-c/c-to-a-adapter.*60 usb-c/c-to-a-adapter.*
@@ -110,6 +112,7 @@ nested_part:
110 usb-c-automated112 usb-c-automated
111 usb-automated113 usb-automated
112 usb3-automated114 usb3-automated
115 thunderbolt-cert-automated
113 watchdog-automated116 watchdog-automated
114 wwan-automated117 wwan-automated
115 com.intel.ipdt::ipdt-plan118 com.intel.ipdt::ipdt-plan

Subscribers

People subscribed via source and target branches

to all changes: