Merge ~rickwu4444/plainbox-provider-certification-client:Add-tb3-to-IOT-and-ODM-UC18-and-20 into plainbox-provider-certification-client:master

Proposed by Rick Wu
Status: Merged
Approved by: Jonathan Cave
Approved revision: fb1fb8e9f5f164af2de546adfc6235ce50487de5
Merged at revision: 197a9321639920afe05745276eab360c3b42dcfe
Proposed branch: ~rickwu4444/plainbox-provider-certification-client:Add-tb3-to-IOT-and-ODM-UC18-and-20
Merge into: plainbox-provider-certification-client:master
Diff against target: 112 lines (+12/-0)
4 files modified
units/client-cert-iot-ubuntucore-18.pxu (+3/-0)
units/client-cert-iot-ubuntucore-20.pxu (+3/-0)
units/client-cert-odm-ubuntucore-18.pxu (+3/-0)
units/client-cert-odm-ubuntucore-20.pxu (+3/-0)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Jonathan Cave (community) Approve
Kristin Chuang (community) Approve
Sylvain Pineau Pending
Review via email: mp+401267@code.launchpad.net

Commit message

Add thunderbolt test into IOT and ODM UC18/20 whitelist

Description of the change

According to Certified Hardware Coverage for Ubuntu Core 18[1] and 20[2]. Add thunderbolt test into whitelist.
[1]http://certification-static.canonical.com/docs/UC18Coverage.pdf
[2]http://certification-static.canonical.com/docs/UC20Coverage.pdf

To post a comment you must log in.
Revision history for this message
Kristin Chuang (kristinchuang) wrote :

+1

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks, I note relevant documentation will be need to be updated to indicate that a Thunderbolt HDD needs to available for testing

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [11:06:45] starting container
Device project added to xenial-testing
[bionic] [11:06:46] starting container
[focal] [11:06:48] starting container
Device project added to bionic-testing
Device project added to focal-testing
[xenial] [11:06:58] provisioning container
[focal] [11:07:06] provisioning container
[bionic] [11:07:07] provisioning container
[xenial] [11:07:09] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-certification-client
[bionic] [11:07:21] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-certification-client
[focal] [11:07:21] Starting tests...
[focal] Found a test script: ./requirements/container-tests-provider-certification-client
[focal] [11:08:18] container-tests-provider-certification-client: PASS
[focal] [11:08:18] Fixing file permissions in source directory
[focal] [11:08:18] Destroying container
[xenial] [11:08:19] container-tests-provider-certification-client: FAIL
[bionic] [11:08:21] container-tests-provider-certification-client: PASS
[bionic] [11:08:21] Fixing file permissions in source directory
[bionic] [11:08:21] Destroying container
[xenial] output: https://paste.ubuntu.com/p/4BHMx2GHfm/
[xenial] [11:08:23] Fixing file permissions in source directory
[xenial] [11:08:23] Destroying container

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/client-cert-iot-ubuntucore-18.pxu b/units/client-cert-iot-ubuntucore-18.pxu
2index 82f6875..de5b962 100644
3--- a/units/client-cert-iot-ubuntucore-18.pxu
4+++ b/units/client-cert-iot-ubuntucore-18.pxu
5@@ -66,6 +66,7 @@ nested_part:
6 usb-manual
7 usb-c-manual
8 usb3-manual
9+ thunderbolt-cert-manual
10 watchdog-manual
11 wireless-manual
12 wireless-wifi-master-mode-manual
13@@ -81,6 +82,7 @@ nested_part:
14 after-suspend-usb-manual
15 after-suspend-usb-c-manual
16 after-suspend-usb3-manual
17+ after-suspend-thunderbolt-cert-manual
18 after-suspend-wireless-manual
19 after-suspend-wireless-wifi-master-mode-manual
20 after-suspend-wwan-manual
21@@ -149,6 +151,7 @@ nested_part:
22 socketcan-auto-remote
23 tpm2.0_3.0.4-automated
24 usb-automated
25+ thunderbolt-cert-automated
26 watchdog-automated
27 wireless-automated
28 wireless-wifi-master-mode-auto
29diff --git a/units/client-cert-iot-ubuntucore-20.pxu b/units/client-cert-iot-ubuntucore-20.pxu
30index a270dfc..3b4c878 100644
31--- a/units/client-cert-iot-ubuntucore-20.pxu
32+++ b/units/client-cert-iot-ubuntucore-20.pxu
33@@ -67,6 +67,7 @@ nested_part:
34 usb-manual
35 usb-c-manual
36 usb3-manual
37+ thunderbolt-cert-manual
38 watchdog-manual
39 wireless-manual
40 wireless-wifi-master-mode-manual
41@@ -82,6 +83,7 @@ nested_part:
42 after-suspend-usb-manual
43 after-suspend-usb-c-manual
44 after-suspend-usb3-manual
45+ after-suspend-thunderbolt-cert-manual
46 after-suspend-wireless-manual
47 after-suspend-wireless-wifi-master-mode-manual
48 after-suspend-wwan-manual
49@@ -151,6 +153,7 @@ nested_part:
50 socketcan-auto-remote
51 tpm2.0_4.1.1-automated
52 usb-automated
53+ thunderbolt-cert-automated
54 watchdog-automated
55 wireless-automated
56 wireless-wifi-master-mode-auto
57diff --git a/units/client-cert-odm-ubuntucore-18.pxu b/units/client-cert-odm-ubuntucore-18.pxu
58index 702bd09..336342a 100644
59--- a/units/client-cert-odm-ubuntucore-18.pxu
60+++ b/units/client-cert-odm-ubuntucore-18.pxu
61@@ -46,6 +46,7 @@ nested_part:
62 usb-c-manual
63 usb-manual
64 usb3-manual
65+ thunderbolt-cert-manual
66 wwan-manual
67 i2c-manual
68 suspend-tp
69@@ -53,6 +54,7 @@ nested_part:
70 after-suspend-bluetooth-manual
71 after-suspend-ethernet-manual
72 after-suspend-wwan-manual
73+ after-suspend-thunderbolt-cert-manual
74 exclude:
75 com.intel.ipdt::ipdt/PCH-.*
76 usb-c/c-to-a-adapter.*
77@@ -110,6 +112,7 @@ nested_part:
78 usb-c-automated
79 usb-automated
80 usb3-automated
81+ thunderbolt-cert-automated
82 watchdog-automated
83 wwan-automated
84 com.intel.ipdt::ipdt-plan
85diff --git a/units/client-cert-odm-ubuntucore-20.pxu b/units/client-cert-odm-ubuntucore-20.pxu
86index b70ca1f..981a819 100644
87--- a/units/client-cert-odm-ubuntucore-20.pxu
88+++ b/units/client-cert-odm-ubuntucore-20.pxu
89@@ -46,6 +46,7 @@ nested_part:
90 usb-c-manual
91 usb-manual
92 usb3-manual
93+ thunderbolt-cert-manual
94 wwan-manual
95 i2c-manual
96 suspend-tp
97@@ -53,6 +54,7 @@ nested_part:
98 after-suspend-bluetooth-manual
99 after-suspend-ethernet-manual
100 after-suspend-wwan-manual
101+ after-suspend-thunderbolt-cert-manual
102 exclude:
103 com.intel.ipdt::ipdt/PCH-.*
104 usb-c/c-to-a-adapter.*
105@@ -110,6 +112,7 @@ nested_part:
106 usb-c-automated
107 usb-automated
108 usb3-automated
109+ thunderbolt-cert-automated
110 watchdog-automated
111 wwan-automated
112 com.intel.ipdt::ipdt-plan

Subscribers

People subscribed via source and target branches

to all changes: