Merge ~rickwu4444/plainbox-provider-certification-client:add-nested-fw-diagnosis-to-iot-plan into plainbox-provider-certification-client:master

Proposed by Rick Wu
Status: Merged
Approved by: Rick Wu
Approved revision: 30b12fd3a03bbbe0028239e3b292097b7a892cf8
Merged at revision: eadee0ace0cfdeb2299541779dcdce6849d8189d
Proposed branch: ~rickwu4444/plainbox-provider-certification-client:add-nested-fw-diagnosis-to-iot-plan
Merge into: plainbox-provider-certification-client:master
Diff against target: 36 lines (+3/-0)
3 files modified
units/client-cert-iot-ubuntucore-16.pxu (+1/-0)
units/client-cert-iot-ubuntucore-18.pxu (+1/-0)
units/client-cert-iot-ubuntucore-20.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Sylvain Pineau Approve
Kristin Chuang (community) Approve
Vic Liu Approve
Rick Wu Needs Resubmitting
Jonathan Cave Pending
Review via email: mp+396889@code.launchpad.net

Commit message

Add fwts test plan into nested part of "client-cert-iot-ubutucore-*.pxu".

Description of the change

Add fwts test plan into "client-cert-iot-*.pxu". Please refer https://code.launchpad.net/~rickwu4444/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/396888" for more details.

To post a comment you must log in.
Revision history for this message
Vic Liu (zongminl) wrote :

I found the plan name firmware-ubuntucore a bit ambiguous, I'd like to propose to have:

iot-firmware-automated nested in the cert whitelist plans

review: Needs Fixing
Revision history for this message
Rick Wu (rickwu4444) wrote :

> I found the plan name firmware-ubuntucore a bit ambiguous, I'd like to propose
> to have:
>
> iot-firmware-automated nested in the cert whitelist plans

fixed!

Revision history for this message
Rick Wu (rickwu4444) wrote :

> I found the plan name firmware-ubuntucore a bit ambiguous, I'd like to propose
> to have:
>
> iot-firmware-automated nested in the cert whitelist plans

fixed!
1.add iot-firmware-automated into nested part of whitelist for UC16/18/20.

review: Needs Resubmitting
Revision history for this message
Vic Liu (zongminl) wrote :

LGTM, +1

review: Approve
Revision history for this message
Kristin Chuang (kristinchuang) wrote :

+1

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/client-cert-iot-ubuntucore-16.pxu b/units/client-cert-iot-ubuntucore-16.pxu
2index fc105a4..ce30baf 100644
3--- a/units/client-cert-iot-ubuntucore-16.pxu
4+++ b/units/client-cert-iot-ubuntucore-16.pxu
5@@ -125,6 +125,7 @@ bootstrap_include:
6 nested_part:
7 self-automated
8 com.intel.ipdt::ipdt-plan
9+ iot-fwts-automated
10 audio-automated
11 bluez-automated
12 camera-automated
13diff --git a/units/client-cert-iot-ubuntucore-18.pxu b/units/client-cert-iot-ubuntucore-18.pxu
14index 0c14773..82f6875 100644
15--- a/units/client-cert-iot-ubuntucore-18.pxu
16+++ b/units/client-cert-iot-ubuntucore-18.pxu
17@@ -125,6 +125,7 @@ bootstrap_include:
18 nested_part:
19 self-automated
20 com.intel.ipdt::ipdt-plan
21+ iot-fwts-automated
22 audio-automated
23 bluez-automated
24 camera-automated
25diff --git a/units/client-cert-iot-ubuntucore-20.pxu b/units/client-cert-iot-ubuntucore-20.pxu
26index e5b0336..a270dfc 100644
27--- a/units/client-cert-iot-ubuntucore-20.pxu
28+++ b/units/client-cert-iot-ubuntucore-20.pxu
29@@ -127,6 +127,7 @@ nested_part:
30 self-automated
31 ubuntucore-automated
32 com.intel.ipdt::ipdt-plan
33+ iot-fwts-automated
34 audio-automated
35 bluez-automated
36 camera-automated

Subscribers

People subscribed via source and target branches

to all changes: