desktopcouch

Merge lp:~rick-rickspencer3/desktopcouch/couchgrid_id_fix into lp:desktopcouch

  1. couchgrid_id_fix
  2. Merge into trunk
Proposed by Rick Spencer
Status: Merged
Approved by: Chad Miller
Approved revision: 85
Merged at revision: not available
Proposed branch: lp:~rick-rickspencer3/desktopcouch/couchgrid_id_fix
Merge into: lp:desktopcouch
Diff against target: 12 lines
1 file modified
desktopcouch/records/couchgrid.py (+1/-1)
To merge this branch: bzr merge lp:~rick-rickspencer3/desktopcouch/couchgrid_id_fix
Reviewer Review Type Date Requested Status
Stuart Langridge (community) Approve
Review via email: mp+13140@code.launchpad.net

Commit message

fix for bug 447512, a one liner

To post a comment you must log in.
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

fix for bug 447512, a one liner

Revision history for this message
Stuart Langridge (sil) wrote :

Seems OK to me -- no tests, mind, but I am sure they will come :-)

review: Approve
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

> Seems OK to me -- no tests, mind, but I am sure they will come :-)

Thanks Stuart ...

1. There is a manual testing facility built directly into couchgrid. If you run the couchgrid module like a program (python CoughGridp.py) you can do the manual test. I ran the manual test and confirmed CouchGrid still worked and that the bug was fixed.

2. I ran all of the tests in desktop records after this change, and they all passed.

3. I'll add an automated test asap to make sure that future similar regressions are caught.

Cheers, Rick

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'desktopcouch/records/couchgrid.py'
2--- desktopcouch/records/couchgrid.py 2009-08-22 17:22:02 +0000
3+++ desktopcouch/records/couchgrid.py 2009-10-09 22:22:11 +0000
4@@ -212,7 +212,7 @@
5 pass
6
7 #set the last value as the document_id, and append
8- row[-1] = r.key
9+ row[-1] = r.value["_id"]
10 self.list_store.append(row)
11
12 #apply the model tot he Treeview

Subscribers

People subscribed via source and target branches