Awesome, thanks for all your work on this. :) I made a bunch of cosmetic changes (I should put
together a style guide for pyOpenSSL, but I'm still not sure what it would say), but notices a
couple more actual potential issues, which I also tried to tackle. My changes are in a branch
based on yours, <lp:~exarkun/pyopenssl/pkcs12_mod_and_export2>. The revisions which actually
contain interesting changes are:
>
> Excellent points! Thanks for the lesson. I pushed all five
> fixes to lp:~rick-fdd/pyopenssl/pkcs12_mod_and_export2
>
Awesome, thanks for all your work on this. :) I made a bunch of cosmetic changes (I should put
together a style guide for pyOpenSSL, but I'm still not sure what it would say), but notices a
couple more actual potential issues, which I also tried to tackle. My changes are in a branch
based on yours, <lp:~exarkun/pyopenssl/pkcs12_mod_and_export2>. The revisions which actually
contain interesting changes are:
http:// bazaar. launchpad. net/~exarkun/ pyopenssl/ pkcs12_ mod_and_ export2/ revision/ 149 bazaar. launchpad. net/~exarkun/ pyopenssl/ pkcs12_ mod_and_ export2/ revision/ 156 bazaar. launchpad. net/~exarkun/ pyopenssl/ pkcs12_ mod_and_ export2/ revision/ 157
http://
http://
I think I'm happy with the code now, so if you think these changes are sensible, I think I'll go ahead and merge them into trunk.
Jean-Paul