Merge lp:~ricgard/maas/set-zone-spacing into lp:~maas-committers/maas/trunk

Proposed by Richard McCartney
Status: Merged
Approved by: Richard McCartney
Approved revision: no longer in the source branch.
Merged at revision: 4086
Proposed branch: lp:~ricgard/maas/set-zone-spacing
Merge into: lp:~maas-committers/maas/trunk
Prerequisite: lp:~ricgard/maas/tag-spacing
Diff against target: 26 lines (+10/-6)
1 file modified
src/maasserver/static/partials/nodes-list.html (+10/-6)
To merge this branch: bzr merge lp:~ricgard/maas/set-zone-spacing
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+263875@code.launchpad.net

Commit message

Resolves set zone action dropdown alignment

Description of the change

Fixes the set zone action dropdown which was not aligned correctly. Added new markup to amend this issue.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/static/partials/nodes-list.html'
2--- src/maasserver/static/partials/nodes-list.html 2015-07-01 10:10:41 +0000
3+++ src/maasserver/static/partials/nodes-list.html 2015-07-13 13:42:38 +0000
4@@ -47,12 +47,16 @@
5 </span>
6 <!-- XXX rbanffy 2015-03-23 - Need to add e2e test. -->
7 <span class="ng-hide" data-ng-show="tabs.nodes.actionOption.name === 'set-zone'">
8- <label for="zone">Select Zone</label>
9- <select name="zone" id="zone" class="three-col" placeholder="Choose a zone"
10- data-ng-model="tabs.nodes.zoneSelection"
11- data-ng-options="zone as zone.name for zone in zones">
12- <option value="" disabled="disabled">Choose a zone</option>
13- </select>
14+ <span class="five-col no-margin-bottom">
15+ <span class="inline">
16+ <label for="zone">Select Zone</label>
17+ <select name="zone" id="zone" class="three-col" placeholder="Choose a zone"
18+ data-ng-model="tabs.nodes.zoneSelection"
19+ data-ng-options="zone as zone.name for zone in zones">
20+ <option value="" disabled="disabled">Choose a zone</option>
21+ </select>
22+ </span>
23+ </span>
24 </span>
25 <div class="right">
26 <a href="" class="margin-right" data-ng-click="actionCancel('nodes')">Cancel</a>