Merge lp:~ricardokirkner/python-oops-amqp/no-pymongo-for-bson into lp:python-oops-amqp

Proposed by Ricardo Kirkner on 2015-10-02
Status: Merged
Approved by: James Westby on 2015-10-08
Approved revision: 23
Merged at revision: 21
Proposed branch: lp:~ricardokirkner/python-oops-amqp/no-pymongo-for-bson
Merge into: lp:python-oops-amqp
Diff against target: 58 lines (+8/-4)
3 files modified
NEWS (+4/-0)
oops_amqp/__init__.py (+2/-2)
setup.py (+2/-2)
To merge this branch: bzr merge lp:~ricardokirkner/python-oops-amqp/no-pymongo-for-bson
Reviewer Review Type Date Requested Status
James Westby (community) 2015-10-02 Approve on 2015-10-08
Ricardo Kirkner (community) Approve on 2015-10-05
Fabián Ezequiel Gallina (community) Approve on 2015-10-05
Review via email: mp+273263@code.launchpad.net

Commit message

do not depend on pymongo when bson is all we need

To post a comment you must log in.
Fabián Ezequiel Gallina (fgallina) wrote :

LGTM

review: Approve
review: Approve
review: Approve
23. By Ricardo Kirkner on 2015-10-08

record dropping pymongo in NEWS file

James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2012-08-10 02:38:21 +0000
3+++ NEWS 2015-10-08 14:49:37 +0000
4@@ -6,6 +6,10 @@
5 NEXT
6 ----
7
8+* Dropped dependency on pymongo in favor of bson. This avoids having
9+ to depend both on bson and pymongo when installing in conjunction
10+ with oops-datedir-repo. (Ricardo Kirkner)
11+
12 0.0.7
13 -----
14
15
16=== modified file 'oops_amqp/__init__.py'
17--- oops_amqp/__init__.py 2012-08-10 03:06:16 +0000
18+++ oops_amqp/__init__.py 2015-10-08 14:49:37 +0000
19@@ -54,7 +54,7 @@
20
21 From time to time your AMQP server may be unavailable. If that happens then
22 the Publisher will not assign an oops id - it will return None to signal that
23-the publication failed. To prevent losing the OOPS its a good idea to have a
24+the publication failed. To prevent losing the OOPS its a good idea to have a
25 fallback publisher - either another AMQP publisher (to a different server) or
26 one that spools locally (where you can pick up the OOPSes via rsync or some
27 other mechanism. Using the oops standard helper publish_with_fallback will let
28@@ -97,7 +97,7 @@
29 # established at this point, and setup.py will use a version of next-$(revno).
30 # If the releaselevel is 'final', then the tarball will be major.minor.micro.
31 # Otherwise it is major.minor.micro~$(revno).
32-__version__ = (0, 0, 8, 'beta', 0)
33+__version__ = (0, 0, 8, 'beta', 1)
34
35 __all__ = [
36 'Publisher',
37
38=== modified file 'setup.py'
39--- setup.py 2012-08-10 03:04:59 +0000
40+++ setup.py 2015-10-08 14:49:37 +0000
41@@ -23,7 +23,7 @@
42 os.path.join(os.path.dirname(__file__), 'README'), 'rb').read()
43
44 setup(name="oops_amqp",
45- version="0.0.8",
46+ version="0.0.8b1",
47 description=\
48 "OOPS AMQP transport.",
49 long_description=description,
50@@ -40,7 +40,7 @@
51 'Programming Language :: Python',
52 ],
53 install_requires = [
54- 'pymongo',
55+ 'bson',
56 'oops>=0.0.11',
57 'amqplib',
58 ],

Subscribers

People subscribed via source and target branches

to all changes: