Merge lp:~ricardokirkner/ols-store-tests/snap-purchases-api into lp:~ubuntuone-pqm-team/ols-store-tests/store-acceptance-tests

[Ricardo Kirkner]

added tests for new snap purchases api

[lp:~ricardokirkner/ols-store-tests/snap-purchases-api]

32. By Ricardo Kirkner on 2016-09-19

make sure store-versions is called after the branch has been updated

33. By Ricardo Kirkner on 2016-09-19

use wheels for dependencies instead of hitting pypi

34. By Ricardo Kirkner on 2016-09-19

pass STRIPE_PUBLISHABLE_KEY to vm environment

[Vincent Ladeuil (vila)]

I didn't review the tests, for the "infra" bits, all look sane.

Thanks for the great work ;)

review: Approve

[lp:~ricardokirkner/ols-store-tests/snap-purchases-api]

35. By Ricardo Kirkner on 2016-09-19

updated snap purchases api urls

=== added file '.bzrignore'
--- .bzrignore	1970-01-01 00:00:00 +0000
+++ .bzrignore	2016-09-19 13:38:27 +0000
@@ -0,0 +1,2 @@
+env
+branches/

=== modified file 'Makefile'
--- Makefile	2016-09-19 12:16:07 +0000
+++ Makefile	2016-09-19 13:38:27 +0000
@@ -1,11 +1,28 @@
 # Copyright (C) 2016 Canonical Ltd.
 
+ENV = $(CURDIR)/env
+PIP = pip3
 PYTHON = python3
 VM = store-acceptance-tests
 VSSH = ols-vms shell ${VM}
 TEST_TARGET ?= discover tests/api
-
-vm-setup: ols-vms.conf
+PROJECT_NAME = ols-store-tests
+WHEELS_DIR = branches/wheels
+WHEELS_BRANCH_URL ?= lp:~ubuntuone-pqm-team/$(PROJECT_NAME)/dependencies
+
+bootstrap: $(ENV) wheels install-wheels
+
+$(ENV):
+	pyvenv --clear --system-site-packages $(ENV)
+
+wheels:
+	[ -d $(WHEELS_DIR) ] && (cd $(WHEELS_DIR) && bzr pull) || (bzr branch $(WHEELS_BRANCH_URL) $(WHEELS_DIR))
+
+install-wheels: ARGS=-r requirements.txt
+install-wheels: $(ENV)
+	$(PIP) install --find-links=$(WHEELS_DIR) --no-index $(ARGS)
+
+vm-setup: ols-vms.conf dependencies.txt
 	if [ `ols-vms status ${VM}` = 'RUNNING' ] ; then ols-vms stop ${VM} ; fi
 	ols-vms setup ${VM}
 	touch vm-setup
@@ -30,7 +47,8 @@
 		TEST_USER_EMAIL=$(TEST_USER_EMAIL) \
 		TEST_USER_PASSWORD=$(TEST_USER_PASSWORD) \
 		TEST_USER_NAMESPACE=$(TEST_USER_NAMESPACE) \
+		STRIPE_PUBLISHABLE_KEY=$(STRIPE_PUBLISHABLE_KEY) \
 		make api-tests'
 
-api-tests:
+api-tests: bootstrap
 	$(PYTHON) -u -m unittest $(TEST_TARGET)

=== added directory 'branches'
=== modified file 'dependencies.txt'
--- dependencies.txt	2016-08-18 12:49:56 +0000
+++ dependencies.txt	2016-09-19 13:38:27 +0000
@@ -1,6 +1,6 @@
 make
 squashfs-tools
 snapcraft
+python3-pip
 python3-pymacaroons
 python3-requests
-

=== added file 'requirements.txt'
--- requirements.txt	1970-01-01 00:00:00 +0000
+++ requirements.txt	2016-09-19 13:38:27 +0000
@@ -0,0 +1,1 @@
+stripe==1.36.0

=== added file 'tests/api/snap/test_snap_purchases_customers.py'
--- tests/api/snap/test_snap_purchases_customers.py	1970-01-01 00:00:00 +0000
+++ tests/api/snap/test_snap_purchases_customers.py	2016-09-19 13:38:27 +0000
@@ -0,0 +1,133 @@
+from __future__ import unicode_literals
+
+import json
+import os
+
+import requests  # fades
+import stripe # fades
+
+from .helpers import (
+    SCA_ROOT_URL,
+    APITestCase,
+    authenticate_with_macaroon,
+)
+
+
+def create_customer(stripe_token, auth=None):
+    headers = {
+        'Content-Type': 'application/json',
+    }
+    if auth is not None:
+        headers['Authorization'] = auth
+    data = {}
+    if stripe_token is not None:
+        data['stripe_token'] = stripe_token
+    url = '{}/purchases/v1/customers'.format(SCA_ROOT_URL)
+    response = requests.post(url, data=json.dumps(data), headers=headers)
+    return response
+
+
+def get_stripe_token():
+    stripe.api_key = os.getenv('STRIPE_PUBLISHABLE_KEY', None)
+    token = stripe.Token.create(card={
+        'number': '4111111111111111',
+        'cvc': '1234',
+        'exp_year': 2032,
+        'exp_month': 12,
+    })
+    return token.id
+
+
+def get_customer(auth=None):
+    headers = {
+        'Content-Type': 'application/json',
+        'Cache-Control': 'no-cache',
+    }
+    if auth is not None:
+        headers['Authorization'] = auth
+    url = '{}/purchases/v1/customers/me'.format(SCA_ROOT_URL)
+    response = requests.get(url, headers=headers)
+    return response
+
+
+class CreateCustomerTestCase(APITestCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super(CreateCustomerTestCase, cls).setUpClass()
+
+        cls.auth = authenticate_with_macaroon()
+
+    def assert_invalid_request(self, response, message=None, extra=None):
+        self.assertEqual(response.status_code, 400)
+        body = response.json()
+        if message is None:
+            message = "The 'stripe_token' field is required."
+        if extra is None:
+            extra = {'field': 'stripe_token'}
+        self.assertEqual(body, {
+            'error_list': [
+                {'code': 'invalid-field',
+                 'message': message,
+                 'extra': extra},
+            ]
+        })
+
+    def assert_customer(self, response):
+        self.assertEqual(response.status_code, 200)
+        body = response.json()
+        self.assertIn('accepted_tos_date', body)
+        self.assertIn('latest_tos_date', body)
+        self.assertIn('latest_tos_accepted', body)
+
+    def test_require_authentication(self):
+        response = create_customer(stripe_token='token')
+        self.assert_require_auth(response)
+
+    def test_create_customer_missing_token(self):
+        response = create_customer(stripe_token=None, auth=self.auth)
+        self.assert_invalid_request(response)
+
+    def test_create_customer_invalid_token(self):
+        response = create_customer(stripe_token='', auth=self.auth)
+        message = "The 'stripe_token' field can not be empty."
+        self.assert_invalid_request(response, message)
+
+    def test_create_customer_bad_token(self):
+        response = create_customer(stripe_token='invalid', auth=self.auth)
+        message = "'invalid' is not a valid stripe_token."
+        extra = {'field': 'stripe_token', 'value': 'invalid'}
+        self.assert_invalid_request(response, message, extra)
+
+    def test_create_customer_success(self):
+        token = get_stripe_token()
+        response = create_customer(stripe_token=token, auth=self.auth)
+        self.assert_customer(response)
+
+
+class GetCustomerTestCase(APITestCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super(GetCustomerTestCase, cls).setUpClass()
+
+        cls.auth = authenticate_with_macaroon()
+
+    def assert_customer(self, response):
+        data = response.json()
+        self.assertIn('latest_tos_date', data)
+        self.assertIn('accepted_tos_date', data)
+        self.assertIn('latest_tos_accepted', data)
+
+    def test_require_authentication(self):
+        response = get_customer()
+        self.assert_require_auth(response)
+
+    def test_get_customer_successful(self):
+        response = get_customer(auth=self.auth)
+        self.assert_success(response)
+        self.assert_customer(response)
+
+    def test_get_customer_bad_auth(self):
+        response = get_customer(auth='invalid')
+        self.assert_require_auth(response)

=== added file 'tests/api/snap/test_snap_purchases_orders.py'
--- tests/api/snap/test_snap_purchases_orders.py	1970-01-01 00:00:00 +0000
+++ tests/api/snap/test_snap_purchases_orders.py	2016-09-19 13:38:27 +0000
@@ -0,0 +1,128 @@
+from __future__ import unicode_literals
+
+import json
+
+import requests  # fades
+
+from .helpers import (
+    SCA_ROOT_URL,
+    APITestCase,
+    authenticate_with_macaroon,
+)
+from .test_snap_purchases_customers import (
+    create_customer,
+    get_stripe_token,
+)
+
+
+SNAP_PACKAGE_SNAP_ID = 'A0KkM9O8Aoht03uQqKwGB7JEZAbTPwnu'
+
+
+def create_order(snap_id, currency=None, amount=None, auth=None):
+    headers = {
+        'Content-Type': 'application/json',
+    }
+    if auth is not None:
+        headers['Authorization'] = auth
+    data = {}
+    if snap_id is not None:
+        data['snap_id'] = snap_id
+    if currency is not None:
+        data['currency'] = currency
+    if amount is not None:
+        data['amount'] = amount
+    url = '{}/purchases/v1/orders'.format(SCA_ROOT_URL)
+    response = requests.post(url, data=json.dumps(data), headers=headers)
+    return response
+
+
+def get_orders(auth=None):
+    headers = {
+        'Content-Type': 'application/json',
+    }
+    if auth is not None:
+        headers['Authorization'] = auth
+    url = '{}/purchases/v1/orders'.format(SCA_ROOT_URL)
+    response = requests.get(url, headers=headers)
+    return response
+
+
+class OrdersTestCase(APITestCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super(OrdersTestCase, cls).setUpClass()
+
+        cls.auth = authenticate_with_macaroon(permissions=['package_purchase'])
+
+    def assert_order_data(self, order):
+        self.assertEqual(order['snap_id'], SNAP_PACKAGE_SNAP_ID)
+        self.assertEqual(order['state'], 'Complete')
+        self.assertEqual(order['currency'], 'USD')
+        self.assertIn('amount', order)
+        self.assertIsNotNone(order['amount'])
+
+
+class CreateOrderTestCase(OrdersTestCase):
+
+    def assert_invalid_request(self, response, message=None, extra=None):
+        self.assertEqual(response.status_code, 400)
+        body = response.json()
+        if message is None:
+            message = "The 'snap_id' field is required."
+        if extra is None:
+            extra = {'field': 'snap_id'}
+        self.assertEqual(body, {
+            'error_list': [
+                {'code': 'invalid-field',
+                 'message': message,
+                 'extra': extra}
+            ]
+        })
+
+    def assert_order(self, response):
+        self.assertEqual(response.status_code, 200)
+        body = response.json()
+        self.assert_order_data(body)
+
+    def test_require_authentication(self):
+        response = create_order(snap_id='snap-id')
+        self.assert_require_auth(response)
+
+    def test_create_order_missing_snap_id(self):
+        response = create_order(snap_id=None, auth=self.auth)
+        self.assert_invalid_request(response)
+
+    def test_create_order_invalid_currency(self):
+        response = create_order(snap_id='snap-id', currency='EUR',
+                                auth=self.auth)
+        message = "'EUR' is not a valid currency."
+        extra = {'field': 'currency', 'value': 'EUR'}
+        self.assert_invalid_request(response, message, extra)
+
+    def test_create_order_success(self):
+        token = get_stripe_token()
+        response = create_customer(stripe_token=token, auth=self.auth)
+        assert response.status_code == 200
+        response = create_order(snap_id=SNAP_PACKAGE_SNAP_ID, auth=self.auth)
+        self.assert_order(response)
+
+
+class GetOrdersTestCase(OrdersTestCase):
+
+    def assert_orders(self, response):
+        self.assertEqual(response.status_code, 200)
+        body = response.json()
+        self.assertIn('orders', body)
+        orders = body['orders']
+        if orders:
+            order = body['orders'][-1]
+            self.assert_order_data(order)
+
+    def test_require_authentication(self):
+        response = get_orders()
+        self.assert_require_auth(response)
+
+    def test_get_orders(self):
+        response = get_orders(auth=self.auth)
+        self.assert_orders(response)