Merge lp:~ricardokirkner/ols-jenkaas/no-more-docker-defaults into lp:~ols-jenkaas-admins/ols-jenkaas/trunk

Proposed by Ricardo Kirkner
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 514
Merged at revision: 514
Proposed branch: lp:~ricardokirkner/ols-jenkaas/no-more-docker-defaults
Merge into: lp:~ols-jenkaas-admins/ols-jenkaas/trunk
Diff against target: 102 lines (+5/-46)
4 files modified
jobs/docker-defaults.yaml (+0/-41)
jobs/isitdeployable.yaml (+2/-2)
jobs/project-defaults.yaml (+1/-1)
jobs/project-docker.yaml (+2/-2)
To merge this branch: bzr merge lp:~ricardokirkner/ols-jenkaas/no-more-docker-defaults
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+330680@code.launchpad.net

Commit message

remove docker specific defaults as they are now the same as the global project defaults

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks OK to me, this will need job rebuilding in jenkaas, right?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'jobs/docker-defaults.yaml'
2--- jobs/docker-defaults.yaml 2017-08-29 18:22:50 +0000
3+++ jobs/docker-defaults.yaml 1970-01-01 00:00:00 +0000
4@@ -1,41 +0,0 @@
5-# Defaults for docker projects
6-- defaults:
7- name: docker
8- container: '{name}'
9- # By default, jobs runs on slaves labeled 'production' only. For
10- # specific cases this can be overriden to specify 'maintenance' or a
11- # specific slave or whatever is needed.
12- node: 'production-docker'
13- # The official trunk is on launchpad
14- trunk: 'lp:{name}'
15- vcs: 'bzr' # Or git
16- # 'setup' is executed with credentials so it can pull branches
17- setup: 'make bootstrap'
18- # 'landing-tests' defines the gate for a merge proposal to land on 'trunk'
19- landing-tests: 'make start-db && make test'
20- # Trunk for the deps (just an example, don't rely on the default value !)
21- deps-trunk: 'lp:~ubuntuone-hackers/{name}/+git/dependencies'
22- # 'deps-setup' is executed with credentials so it can pull branches
23- deps-setup: '/bin/true'
24- # 'deps-landing-tests' defines the gate for a merge proposal to land on 'trunk'
25- deps-landing-tests: '/bin/true'
26- # 'docker-container'
27- docker-container: '{name}'
28- # 'docker-setup' is executed with credentials so it can pull branches
29- docker-setup: '/bin/true'
30- # 'docker-build' defines the command to build the docker image
31- docker-build: '/bin/true'
32- job-timeout: 60
33- # Each job has its own directory under a project directory
34- workspace: workspace/{name}/$JOB_NAME
35- # The working directory inside the workspace
36- workdir: 'work'
37- wrappers:
38- - timeout:
39- fail: true
40- type: absolute
41- # No job should take more than 'timeout' minutes
42- timeout: '{job-timeout}'
43- write-description: "Timeout exceeded: {job-timeout} mins"
44- production: !include: is-production.yaml
45- testing: !include: is-testing.yaml
46
47=== modified file 'jobs/isitdeployable.yaml'
48--- jobs/isitdeployable.yaml 2017-09-12 13:20:44 +0000
49+++ jobs/isitdeployable.yaml 2017-09-13 13:56:44 +0000
50@@ -30,7 +30,7 @@
51
52 - project:
53 name: 'isitdeployable-docker'
54- defaults: docker
55+ defaults: project
56 trunk: 'lp:isitdeployable'
57 docker-setup: "make fetch-sourcedeps"
58 docker-build: "make k8s-build k8s-upload DOCKER_REGISTRY=prod-ols.docker-registry.canonical.com IMAGE_TAG=trunk-\\$(bzr revno)"
59@@ -42,7 +42,7 @@
60
61 - project:
62 name: 'isitdeployable-rollout'
63- defaults: docker
64+ defaults: project
65 vcs: 'git'
66 trunk: 'lp:ols-k8s'
67 rollout-command: "make -C isitdeployable/production release IMAGE_TAG=${{IMAGE_TAG}}"
68
69=== modified file 'jobs/project-defaults.yaml'
70--- jobs/project-defaults.yaml 2017-08-10 19:26:30 +0000
71+++ jobs/project-defaults.yaml 2017-09-13 13:56:44 +0000
72@@ -23,7 +23,7 @@
73 docker-container: '{name}'
74 # 'docker-setup' is executed with credentials so it can pull branches
75 docker-setup: '/bin/true'
76- # 'docker-build' defines the command the build the docker image
77+ # 'docker-build' defines the command to build the docker image
78 docker-build: '/bin/true'
79 job-timeout: 60
80 # Each job has its own directory under a project directory
81
82=== modified file 'jobs/project-docker.yaml'
83--- jobs/project-docker.yaml 2017-09-06 19:18:30 +0000
84+++ jobs/project-docker.yaml 2017-09-13 13:56:44 +0000
85@@ -8,7 +8,7 @@
86
87 - job-template:
88 name: '{name}-build-docker-image'
89- defaults: docker
90+ defaults: project
91 description: 'Build docker image for {name}'
92 disabled: !include: is-testing.yaml
93 project-type: freestyle
94@@ -24,7 +24,7 @@
95 - job-template:
96 name: '{name}-rollout-kubernetes'
97 description: 'Rollout latest docker image for {name} to Kubernetes cluster'
98- defaults: docker
99+ defaults: project
100 disabled: !include: is-testing.yaml
101 project-type: freestyle
102 parameters:

Subscribers

People subscribed via source and target branches