Merge lp:~ricardokirkner/isitdeployable/clean-docker-image into lp:isitdeployable

Proposed by Ricardo Kirkner
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 291
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~ricardokirkner/isitdeployable/clean-docker-image
Merge into: lp:isitdeployable
Diff against target: 23 lines (+6/-0)
1 file modified
Makefile.k8s (+6/-0)
To merge this branch: bzr merge lp:~ricardokirkner/isitdeployable/clean-docker-image
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
Review via email: mp+343194@code.launchpad.net

Commit message

added make rule to clean docker image

To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) :
Revision history for this message
Adam Collard (adam-collard) :
review: Approve
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :
291. By Ricardo Kirkner

fixed syntax in makefile

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile.k8s'
2--- Makefile.k8s 2017-11-10 16:18:36 +0000
3+++ Makefile.k8s 2018-04-13 14:01:54 +0000
4@@ -8,6 +8,7 @@
5
6 # public targets
7
8+.PHONY: k8s-build
9 k8s-build: fetch-sourcedeps ## Build container image
10 @echo 'Building image on:' $(shell lsb_release -cs)
11 @echo 'Building image using docker version:' $(shell docker version -f "Server: {{.Server.Version}} Client: {{.Client.Version}}")
12@@ -23,6 +24,11 @@
13 endif
14 docker build $(BUILD_ARGS) -t $(IMAGE_NAME):$(IMAGE_TAG) .
15
16+.PHONY: k8s-upload
17 k8s-upload: ## Upload image to registry
18 docker tag $(IMAGE_NAME):$(IMAGE_TAG) $(DOCKER_REGISTRY)/$(IMAGE_NAME):$(IMAGE_TAG)
19 docker push $(DOCKER_REGISTRY)/$(IMAGE_NAME):$(IMAGE_TAG)
20+
21+.PHONY: k8s-clean
22+k8s-clean: ## Remove image
23+ docker rmi $(shell docker image list -q $(IMAGE_NAME):$(IMAGE_TAG))

Subscribers

People subscribed via source and target branches