Merge lp:~ricardokirkner/django-piston/django-1.11 into lp:django-piston

Proposed by Ricardo Kirkner
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 8
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~ricardokirkner/django-piston/django-1.11
Merge into: lp:django-piston
Diff against target: 144 lines (+38/-23)
3 files modified
demo/urls.py (+3/-4)
piston/emitters.py (+9/-6)
tox.ini (+26/-13)
To merge this branch: bzr merge lp:~ricardokirkner/django-piston/django-1.11
Reviewer Review Type Date Requested Status
Matias Bordese (community) Approve
Review via email: mp+322705@code.launchpad.net

Commit message

support django up to 1.11

To post a comment you must log in.
Revision history for this message
Matias Bordese (matiasb) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'demo/urls.py'
2--- demo/urls.py 2015-04-24 22:17:32 +0000
3+++ demo/urls.py 2017-04-18 17:58:53 +0000
4@@ -1,11 +1,10 @@
5-from django.conf.urls import patterns, include, url
6+from django.conf.urls import include, url
7 from django.contrib import admin
8
9-urlpatterns = patterns(
10- '',
11+urlpatterns = [
12 # Examples:
13 # url(r'^$', 'demo.views.home', name='home'),
14 # url(r'^blog/', include('blog.urls')),
15
16 url(r'^admin/', include(admin.site.urls)),
17-)
18+]
19
20=== modified file 'piston/emitters.py'
21--- piston/emitters.py 2015-04-27 15:30:47 +0000
22+++ piston/emitters.py 2017-04-18 17:58:53 +0000
23@@ -17,7 +17,10 @@
24 from django.utils.xmlutils import SimplerXMLGenerator
25 from django.utils.encoding import smart_unicode
26 from django.core.urlresolvers import NoReverseMatch
27-from django.core.serializers.json import DateTimeAwareJSONEncoder
28+try:
29+ from django.core.serializers.json import DjangoJSONEncoder
30+except ImportError:
31+ from django.core.serializers.json import DateTimeAwareJSONEncoder as DjangoJSONEncoder
32 from django.http import HttpResponse
33 from django.core import serializers
34
35@@ -86,7 +89,7 @@
36 ret = None
37
38 # return anything we've already seen as a string only
39- # this prevents infinite recursion in the case of recursive
40+ # this prevents infinite recursion in the case of recursive
41 # relationships
42
43 if thing in self.stack:
44@@ -160,8 +163,8 @@
45 # the nested models won't appear properly
46 # Refs #157
47 if handler:
48- fields = getattr(handler, 'fields')
49-
50+ fields = getattr(handler, 'fields')
51+
52 if not fields or hasattr(handler, 'fields'):
53 """
54 Fields was not specified, try to find teh correct
55@@ -177,7 +180,7 @@
56 if not get_fields:
57 get_fields = set([ f.attname.replace("_id", "", 1)
58 for f in data._meta.fields + data._meta.virtual_fields])
59-
60+
61 if hasattr(mapped, 'extra_fields'):
62 get_fields.update(mapped.extra_fields)
63
64@@ -391,7 +394,7 @@
65 """
66 def render(self, request):
67 cb = request.GET.get('callback', None)
68- seria = json.dumps(self.construct(), cls=DateTimeAwareJSONEncoder, ensure_ascii=False, indent=4)
69+ seria = json.dumps(self.construct(), cls=DjangoJSONEncoder, ensure_ascii=False, indent=4)
70
71 # Callback
72 if cb and is_valid_jsonp_callback_value(cb):
73
74=== modified file 'tox.ini'
75--- tox.ini 2015-04-24 22:17:32 +0000
76+++ tox.ini 2017-04-18 17:58:53 +0000
77@@ -1,41 +1,54 @@
78 [tox]
79 envlist =
80- py2.7-django1.4, py2.7-django1.5, py2.7-django1.6, py2.7-django1.7, py2.7-django1.8
81+ py27-django1.4, py27-django1.5, py27-django1.6, py27-django1.7, py27-django1.8, py27-django1.9, py27-django1.10, py27-django1.11
82
83 [testenv]
84 commands = python manage.py test piston
85 deps=
86 mock
87
88-[testenv:py2.7-django1.4]
89+[testenv:py27]
90 basepython = python2.7
91+
92+[testenv:py27-django1.4]
93 deps =
94 django >= 1.4, < 1.5
95+ south==1.0
96 {[testenv]deps}
97- south==1.0
98
99-[testenv:py2.7-django1.5]
100-basepython = python2.7
101+[testenv:py27-django1.5]
102 deps =
103 django >= 1.5, < 1.6
104+ south==1.0
105 {[testenv]deps}
106- south==1.0
107
108-[testenv:py2.7-django1.6]
109-basepython = python2.7
110+[testenv:py27-django1.6]
111 deps =
112 django >= 1.6, < 1.7
113+ south==1.0
114 {[testenv]deps}
115- south==1.0
116
117-[testenv:py2.7-django1.7]
118-basepython = python2.7
119+[testenv:py27-django1.7]
120 deps =
121 django >= 1.7, < 1.8
122 {[testenv]deps}
123
124-[testenv:py2.7-django1.8]
125-basepython = python2.7
126+[testenv:py27-django1.8]
127 deps =
128 django >= 1.8, < 1.9
129 {[testenv]deps}
130+
131+[testenv:py27-django1.9]
132+deps =
133+ django >= 1.9, < 1.10
134+ {[testenv]deps}
135+
136+[testenv:py27-django1.10]
137+deps =
138+ django >= 1.10, < 1.11
139+ {[testenv]deps}
140+
141+[testenv:py27-django1.11]
142+deps =
143+ django >= 1.11, < 1.12
144+ {[testenv]deps}

Subscribers

People subscribed via source and target branches