Canonical SSO provider

Merge lp:~ricardokirkner/canonical-identity-provider/saml-with-session-index into lp:canonical-identity-provider/release

  1. saml-with-session-index
  2. Merge into trunk
Proposed by Ricardo Kirkner
Status: Merged
Approved by: Daniel Manrique
Approved revision: no longer in the source branch.
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~ricardokirkner/canonical-identity-provider/saml-with-session-index
Merge into: lp:canonical-identity-provider/release
Diff against target: 30 lines (+8/-1)
2 files modified
config-manager.txt (+1/-1)
src/ubuntu_sso_saml/tests/test_processors.py (+7/-0)
To merge this branch: bzr merge lp:~ricardokirkner/canonical-identity-provider/saml-with-session-index
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+343333@code.launchpad.net

Commit message

bump saml2idp library to support SessionIndex in AuthnStatement

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, thanks!

review: Approve
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Project setup failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider/107/

Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider/108/

Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider/109/

Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider/110/

Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider/111/

Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider/112/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config-manager.txt'
2--- config-manager.txt 2018-03-15 19:52:50 +0000
3+++ config-manager.txt 2018-04-16 16:43:32 +0000
4@@ -5,7 +5,7 @@
5 branches/django-openid-auth lp:~ubuntuone-pqm-team/django-openid-auth/trunk;revno=129,overwrite=true
6 branches/django-pgtools lp:django-pgtools;revno=14,overwrite=true
7 branches/django-piston lp:~ubuntuone-pqm-team/django-piston/trunk;revno=14,overwrite=true
8-branches/django-saml2-idp lp:~ubuntuone-pqm-team/django-saml2-idp/stable;revno=72,overwrite=true
9+branches/django-saml2-idp lp:~ubuntuone-pqm-team/django-saml2-idp/stable;revno=73,overwrite=true
10 branches/ols-tests lp:ols-tests;tag=ols-tests-1.0.0,overwrite=true
11 branches/ols-tests-django lp:ols-tests-django;revno=20,overwrite=true
12 branches/python-openid lp:~ubuntuone-pqm-team/python-openid/stable;revno=1989,overwrite=true
13
14=== modified file 'src/ubuntu_sso_saml/tests/test_processors.py'
15--- src/ubuntu_sso_saml/tests/test_processors.py 2018-04-10 16:17:56 +0000
16+++ src/ubuntu_sso_saml/tests/test_processors.py 2018-04-16 16:43:32 +0000
17@@ -1399,6 +1399,13 @@
18 response = client.post('/+saml', data=data, follow=False)
19 self.assertEqual(response.status_code, 302)
20
21+ def test_session_index_in_response(self):
22+ self.setup_saml_sp()
23+
24+ data = self.get_request_data()
25+ samlresponse = self.do_saml_request(data=data)
26+ self.assertIn('SessionIndex=', samlresponse)
27+
28 def test_canonical_email_is_preferred(self):
29 self.setup_saml_sp(prefer_canonical_email=True)
30 preferred = self.setup_saml_emails()