Merge lp:~ricardokirkner/canonical-identity-provider/904880-fix-broken-template into lp:~canonical-isd-hackers/canonical-identity-provider/stable

Proposed by Ricardo Kirkner
Status: Merged
Approved by: David Owen
Approved revision: no longer in the source branch.
Merged at revision: 162
Proposed branch: lp:~ricardokirkner/canonical-identity-provider/904880-fix-broken-template
Merge into: lp:~canonical-isd-hackers/canonical-identity-provider/stable
Diff against target: 43 lines (+14/-1)
2 files modified
identityprovider/tests/test_views_ui.py (+12/-0)
identityprovider/views/ui.py (+2/-1)
To merge this branch: bzr merge lp:~ricardokirkner/canonical-identity-provider/904880-fix-broken-template
Reviewer Review Type Date Requested Status
David Owen (community) Approve
Review via email: mp+85946@code.launchpad.net

Commit message

Fix unstyled template on logout-to-confirm view.

The template broke because the view wasn't using a RequestContext object.

Description of the change

Fix unstyled template on logout-to-confirm view.

The template broke because the view wasn't using a RequestContext object.

To post a comment you must log in.
Revision history for this message
David Owen (dsowen) wrote :

Great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'identityprovider/tests/test_views_ui.py'
2--- identityprovider/tests/test_views_ui.py 2011-11-29 18:06:51 +0000
3+++ identityprovider/tests/test_views_ui.py 2011-12-15 20:20:31 +0000
4@@ -14,6 +14,8 @@
5 from django.core import mail
6 from django.core.urlresolvers import Resolver404
7 from django.http import QueryDict, HttpResponse
8+from django.shortcuts import render_to_response
9+from django.template import RequestContext
10 from django.test.client import Client
11 from django.utils.http import urlquote
12
13@@ -324,6 +326,16 @@
14 r = self.client.get('/+logout-to-confirm')
15 self.assertEquals(r.status_code, 200)
16
17+ @patch('identityprovider.views.ui.render_to_response')
18+ def test_logout_to_confirm_use_request_context(self,
19+ mock_render_to_response):
20+ mock_render_to_response.side_effect = render_to_response
21+
22+ self.client.get('/+logout-to-confirm')
23+ context = mock_render_to_response.call_args[0][1]
24+ self.assertTrue(isinstance(context, RequestContext))
25+
26+
27 def test_confirm_account_while_logged_in(self):
28 token = self.create_token(at.LoginTokenType.NEWPERSONLESSACCOUNT,
29 email='me@example.com')
30
31=== modified file 'identityprovider/views/ui.py'
32--- identityprovider/views/ui.py 2011-11-29 15:51:53 +0000
33+++ identityprovider/views/ui.py 2011-12-15 20:20:31 +0000
34@@ -641,7 +641,8 @@
35
36
37 def logout_to_confirm(request):
38- return render_to_response('registration/logout_to_confirm.html')
39+ return render_to_response('registration/logout_to_confirm.html',
40+ RequestContext(request))
41
42
43 def deactivated(request):

Subscribers

People subscribed via source and target branches