Merge lp:~rhuddie/address-book-app/add-photo-helper into lp:address-book-app
Proposed by
Richard Huddie
Status: | Needs review |
---|---|
Proposed branch: | lp:~rhuddie/address-book-app/add-photo-helper |
Merge into: | lp:address-book-app |
Diff against target: |
206 lines (+94/-7) 6 files modified
debian/control (+1/-0) src/imports/ContactEdit/ContactDetailAvatarEditor.qml (+1/-0) tests/autopilot/address_book_app/pages/_contact_editor.py (+33/-4) tests/autopilot/address_book_app/pages/_contact_list_page.py (+11/-0) tests/autopilot/address_book_app/tests/__init__.py (+22/-0) tests/autopilot/address_book_app/tests/test_edit_contact.py (+26/-3) |
To merge this branch: | bzr merge lp:~rhuddie/address-book-app/add-photo-helper |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Needs Fixing | |
Leo Arias (community) | Needs Fixing | ||
Ubuntu Phablet Team | Pending | ||
Review via email: mp+227519@code.launchpad.net |
Description of the change
New helper method and test for adding a photo to a contact.
Requires content-
To post a comment you must log in.
Unmerged revisions
- 230. By Richard Huddie
-
merge from trunk
- 229. By Richard Huddie
-
fix flake8
- 228. By Richard Huddie
-
test now working
- 227. By Richard Huddie
-
add content-
hub-testability dependency - 226. By Richard Huddie
-
add expected path validation
- 225. By Richard Huddie
-
move url conversion to contact editor
- 224. By Richard Huddie
-
merge trunk
- 223. By Richard Huddie
-
test updates and add def get_contact_
avatar_ file_path( self): - 222. By Richard Huddie
-
add get_contact_
avatar_ file_path( ) to ContactListPage helper - 221. By Richard Huddie
-
added fake url dispatcher
FAILED: Continuous integration, rev:229 /code.launchpad .net/~rhuddie/ address- book-app/ add-photo- helper/ +merge/ 227519/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ address- book-app- ci/619/ jenkins. qa.ubuntu. com/job/ address- book-app- utopic- amd64-ci/ 72 jenkins. qa.ubuntu. com/job/ address- book-app- utopic- armhf-ci/ 72 jenkins. qa.ubuntu. com/job/ address- book-app- utopic- armhf-ci/ 72/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ address- book-app- utopic- i386-ci/ 72 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- utopic- touch/2220/ console jenkins. qa.ubuntu. com/job/ generic- mediumtests- utopic/ 1851/console jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/2430/ console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/3401 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/3401/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 10121 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-utopic/ 1555/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/2070 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/2070/ artifact/ work/output/ *zip*/output. zip
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/address- book-app- ci/619/ rebuild
http://