Merge lp:~rharding/lazr.restfulclient/basic_auth into lp:lazr.restfulclient
Proposed by
Richard Harding
Status: | Merged |
---|---|
Merged at revision: | 129 |
Proposed branch: | lp:~rharding/lazr.restfulclient/basic_auth |
Merge into: | lp:lazr.restfulclient |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp:~rharding/lazr.restfulclient/basic_auth |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ian Booth (community) | Approve | ||
Review via email: mp+106282@code.launchpad.net |
Commit message
Implement the authorizeRequest for the BasicHttpAuthor
Description of the change
= Summary =
The BasicHttpAuthorizer has a method to auth a request with basic http auth,
however it wasn't implemented. Only the method for auth'ing a session was.
This adds a working method to add the correct header.
== Implementation Notes ==
Basic http auth is just the username:password base64'd. This implements that
into the authorization header.
== Tests ==
Added a new doctest to hit this specific method. It doesn't fit the 'flow' of
the current doctests, but just wanted something that verifies it encodes
properly.
Tests run via buildout:
./bin/test
To post a comment you must log in.
This looks fine.
You need to update NEWS.txt and version.txt before packaging and uploading to pypi.