Merge lp:~rharding/launchpad/yui35_test_fix2 into lp:launchpad
Proposed by
Richard Harding
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 15808 | ||||
Proposed branch: | lp:~rharding/launchpad/yui35_test_fix2 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
375 lines (+63/-64) 10 files modified
lib/lp/app/javascript/choiceedit/choiceedit.js (+2/-2) lib/lp/app/javascript/choiceedit/tests/test_choiceedit.js (+3/-6) lib/lp/app/javascript/testing/assert.js (+2/-1) lib/lp/app/javascript/testing/helpers.js (+3/-3) lib/lp/bugs/javascript/bug_picker.js (+5/-6) lib/lp/bugs/javascript/tests/test_bug_picker.js (+6/-5) lib/lp/bugs/javascript/tests/test_duplicates.js (+20/-19) lib/lp/registry/javascript/sharing/granteepicker.js (+3/-3) lib/lp/registry/javascript/sharing/granteetable.js (+3/-3) lib/lp/registry/javascript/sharing/tests/test_granteetable.js (+16/-16) |
||||
To merge this branch: | bzr merge lp:~rharding/launchpad/yui35_test_fix2 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Deryck Hodge (community) | Approve | ||
Curtis Hovey (community) | code | Approve | |
Review via email: mp+119603@code.launchpad.net |
Commit message
Update JS and tests to pass under YUI 3.5.1.
Description of the change
This branch corrects tests and js code so that they all pas under YUI 3.5.1. This brings things back into alignment with the work previously done to update the JS code to prepare for testing YUI 3.5.1 behind the feature flag.
Since tests currently only run under 3.3.0, it's easy for them to get out of sync with the changes required for 3.5.1.
To post a comment you must log in.
Thank you for these fixes.