Merge lp:~rharding/launchpad/remove_mustache into lp:launchpad

Proposed by Richard Harding on 2012-06-22
Status: Merged
Approved by: Aaron Bentley on 2012-06-22
Approved revision: no longer in the source branch.
Merged at revision: 15487
Proposed branch: lp:~rharding/launchpad/remove_mustache
Merge into: lp:launchpad
To merge this branch: bzr merge lp:~rharding/launchpad/remove_mustache
Reviewer Review Type Date Requested Status
Aaron Bentley (community) 2012-06-22 Approve on 2012-06-22
Review via email: mp+111633@code.launchpad.net

Commit Message

Remove mustache.js from the sourcedeps list.

Description of the Change

Per the bug, we've subsumed mustache into lib/app/js/mustache.js and ported all code using mustache to Y.app.mustache.

There is no need to pull the mustache dep into the sourcecode directory. This change just removes that from the config.

To post a comment you must log in.
Aaron Bentley (abentley) wrote :

I don't think it's a good idea to fork mustache.js, and I've filed bug #1016668 about it. However, with the current state of the code, removing the sourcecode line does no harm.

review: Approve