Merge lp:~rharding/launchpad/remove_assigned_specs_1068817 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Aaron Bentley |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16204 |
Proposed branch: | lp:~rharding/launchpad/remove_assigned_specs_1068817 |
Merge into: | lp:launchpad |
Prerequisite: | lp:~rharding/launchpad/fix_flash_1066898 |
Diff against target: |
101 lines (+15/-14) 4 files modified
lib/lp/registry/doc/person-account.txt (+5/-2) lib/lp/registry/doc/person.txt (+3/-1) lib/lp/registry/interfaces/person.py (+0/-2) lib/lp/registry/model/person.py (+7/-9) |
To merge this branch: | bzr merge lp:~rharding/launchpad/remove_assigned_specs_1068817 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+131558@code.launchpad.net |
This proposal supersedes a proposal from 2012-10-26.
Commit message
Remove person.
Description of the change
= Summary =
person.
to shoot yourself in the foot since it doesn't deal with checking permissions
on items.
Its single use case is in tests and deactivating an account when you do in
fact want to make sure you catch all specifications that need to be
unassigned.
== Pre Implementation ==
Had a chat with Aaron around the reasoning for cleaning this up.
== Implementation Notes ==
We just replace the simple query directly into the deactivate account work.
It's doing a lot of work and this doesn't add much to it.
The larger update is to the tests since many of the doctests used this as a
shortcut to get to the list of assigned specs.
== Tests ==
registry/
registry/