Merge lp:~rharding/launchpad/pp_register into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Richard Harding |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15948 |
Proposed branch: | lp:~rharding/launchpad/pp_register |
Merge into: | lp:launchpad |
Diff against target: |
367 lines (+120/-15) 9 files modified
lib/lp/app/javascript/choice.js (+3/-0) lib/lp/registry/browser/product.py (+70/-7) lib/lp/registry/browser/tests/test_product.py (+2/-1) lib/lp/registry/interfaces/product.py (+16/-2) lib/lp/registry/model/product.py (+19/-2) lib/lp/registry/model/projectgroup.py (+1/-1) lib/lp/registry/stories/webservice/xx-project-registry.txt (+1/-0) lib/lp/registry/templates/product-new.pt (+7/-1) lib/lp/registry/tests/test_pillaraffiliation.py (+1/-1) |
To merge this branch: | bzr merge lp:~rharding/launchpad/pp_register |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+122666@code.launchpad.net |
Commit message
Add start of UI for selecting private projects during registration.
Description of the change
= Summary =
In order to allow creation or private projects we need to enable a drop down
to display information type.
Private projects will also get bugs, branches, and blueprints on by default so
selecting a driver and bug supervisor is moved up to project registration as
well.
== Pre Implementation ==
Lots of discussion about which fields to add and about choosing the three
valid information types for a 'private' project to be public, embargoed, and
proprietary.
== Implementation Notes ==
All work is hidden behind the private projects feature flag.
Deryck is working on the information type field in the database so this work
simply adds the property without storing. This merely adds the UI to select a
value during registration if the feature flag is enabled, but doesn't store
that value.
Bug supervisor and driver are intended to only be shown if the project is not
public, this will be done in a follow up branch since it's currently behind
the flag.
These changes are only applicable to +new project registration and so are
checked against the interface for IProductSet and not enabled for
ProjectGroup.
== Tests ==
All current tests pass. New tests will be forth coming as the db field is
properly stored and tests for the UI adjustments will be done in the
javascript tests in a follow up branch.
Looks great.