Merge lp:~rharding/launchpad/pagination_905228 into lp:launchpad

Proposed by Richard Harding
Status: Merged
Approved by: Richard Harding
Approved revision: no longer in the source branch.
Merged at revision: 14534
Proposed branch: lp:~rharding/launchpad/pagination_905228
Merge into: lp:launchpad
Diff against target: 11 lines (+0/-1)
1 file modified
lib/lp/bugs/javascript/buglisting.js (+0/-1)
To merge this branch: bzr merge lp:~rharding/launchpad/pagination_905228
Reviewer Review Type Date Requested Status
Abel Deuring (community) code Approve
Review via email: mp+86033@code.launchpad.net

Commit message

[r=adeuring][bug=905228] Remove calling the initializer of the superclass ourselves, let yui chain that for us.

Description of the change

= Summary =
In chrome, the bug listing pagination would fail due to missing batch information in the model.

== Implementation ==
There was a duplicate call to the superclass's initializer. YUI will chain those for us and calling again just caused another pass through there that caused init issues when chained with Chrome's popping of the history on page load by default.

== Tests ==
lib/lp/bugs/javascript/tests/test_buglisting.html
lib/lp/app/javascript/tests/test_listing_navigator.html

To post a comment you must log in.
Revision history for this message
Abel Deuring (adeuring) wrote :

looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/javascript/buglisting.js'
2--- lib/lp/bugs/javascript/buglisting.js 2011-12-14 19:23:02 +0000
3+++ lib/lp/bugs/javascript/buglisting.js 2011-12-16 12:36:26 +0000
4@@ -122,7 +122,6 @@
5 module.BugListingNavigator,
6 Y.lp.app.listing_navigator.ListingNavigator, {
7 initializer: function(config) {
8- this.constructor.superclass.initializer.apply(this, arguments);
9 this.get('model').get('history').after(
10 'change', this.history_changed, this);
11 },