Merge lp:~rharding/launchpad/pagination_905228 into lp:launchpad
Proposed by
Richard Harding
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Richard Harding | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 14534 | ||||
Proposed branch: | lp:~rharding/launchpad/pagination_905228 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
11 lines (+0/-1) 1 file modified
lib/lp/bugs/javascript/buglisting.js (+0/-1) |
||||
To merge this branch: | bzr merge lp:~rharding/launchpad/pagination_905228 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+86033@code.launchpad.net |
Commit message
[r=adeuring][bug=905228] Remove calling the initializer of the superclass ourselves, let yui chain that for us.
Description of the change
= Summary =
In chrome, the bug listing pagination would fail due to missing batch information in the model.
== Implementation ==
There was a duplicate call to the superclass's initializer. YUI will chain those for us and calling again just caused another pass through there that caused init issues when chained with Chrome's popping of the history on page load by default.
== Tests ==
lib/lp/
lib/lp/
To post a comment you must log in.
looks good.