Launchpad itself

Merge lp:~rharding/launchpad/no_more_tmp into lp:launchpad

  1. no_more_tmp
  2. Merge into devel
Proposed by Richard Harding
Status: Merged
Approved by: Aaron Bentley
Approved revision: no longer in the source branch.
Merged at revision: 15689
Proposed branch: lp:~rharding/launchpad/no_more_tmp
Merge into: lp:launchpad
Diff against target: 16 lines (+3/-3)
1 file modified
buildout.cfg (+3/-3)
To merge this branch: bzr merge lp:~rharding/launchpad/no_more_tmp
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+116663@code.launchpad.net

Commit message

Do not extract yui .zip files into system tmp, but into the build directory and clean it up.

Description of the change

Per request from William, moved the extraction directory out of the system /tmp and into the build directory.

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

I find file extensions in directory names surprising. Please use ${buildout:yui-directory}/yui-${:yui_version}-extracted or ${buildout:yui-directory}/yui-${:yui_version}-tmp or something.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'buildout.cfg'
2--- buildout.cfg 2012-07-18 17:36:00 +0000
3+++ buildout.cfg 2012-07-25 15:16:22 +0000
4@@ -43,9 +43,9 @@
5 command =
6 mkdir -p ${buildout:yui-directory}/yui-${:yui_version}
7 rm -rf ${buildout:yui-directory}/yui-${:yui_version}/*
8- unzip -q download-cache/dist/yui_${:yui_version}.zip -d /tmp/yui-${:yui_version}
9- mv /tmp/yui-${:yui_version}/yui/build/* ${buildout:yui-directory}/yui-${:yui_version}
10- rm -rf /tmp/yui-${:yui_version}
11+ unzip -q download-cache/dist/yui_${:yui_version}.zip -d ${buildout:yui-directory}/yui-${:yui_version}-tmp
12+ mv ${buildout:yui-directory}/yui-${:yui_version}-tmp/yui/build/* ${buildout:yui-directory}/yui-${:yui_version}
13+ rm -rf ${buildout:yui-directory}/yui-${:yui_version}-tmp
14
15 [yui-default]
16 <= yui