Merge lp:~rharding/launchpad/lpyui-dep into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Richard Harding |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15615 |
Proposed branch: | lp:~rharding/launchpad/lpyui-dep |
Merge into: | lp:launchpad |
Diff against target: |
123 lines (+10/-19) 6 files modified
Makefile (+2/-2) buildout-templates/bin/combo-rootdir.in (+1/-0) buildout.cfg (+3/-14) lib/lp/app/templates/base-layout-macros.pt (+3/-2) utilities/check-js-deps (+0/-1) versions.cfg (+1/-0) |
To merge this branch: | bzr merge lp:~rharding/launchpad/lpyui-dep |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+114430@code.launchpad.net |
Commit message
Wire up the js.yui_version feature flag and have combo-rootdir use the launchpad_yui package for extracting YUI.
Description of the change
= Summary =
In order to test different YUI versions behind the feature flag, we need to
have the ability to load up multiple versions into the combo loader directory
and to change which version you get based on the feature flag setting:
js.yui_version
== Pre Implementation ==
Talked with Orange and Curtis on methods of packaging up the YUI depenency.
Using the new launchpad_yui package to extract out the current working library
versions.
== Implementation Notes ==
Since we're loading YUI out of the python package we have to update our
versions.
we then use in combo-rootdir to extract the YUI versions. This moves the
responsiblity for populating the build dir from buildout to the combo-rootdir
script.
This also updates the YUI config to use the already built in value for the
js.yui_version feature flag. When not set, it's set to yui and uses the
default symlink. Otherwise you can specify the actual version file.
Currently you can use the feature flag below to run under the latest 3.5.1
release.
js.yui_version default 1 yui-3.5.1
== Tests ==
All tests should pass as normal. No new tests for this.
== LoC Qualification ==
This is a negative LoC impact.
This looks ok to me, but I'll be the first to point out that I'm not a make/buildout expert. It may be worth following up with others with more experience in this part of our code.