Merge lp:~rharding/launchpad/ec2_land_928853 into lp:launchpad
Proposed by
Richard Harding
Status: | Merged |
---|---|
Approved by: | Richard Harding |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14766 |
Proposed branch: | lp:~rharding/launchpad/ec2_land_928853 |
Merge into: | lp:launchpad |
Diff against target: |
13 lines (+2/-1) 1 file modified
lib/devscripts/autoland.py (+2/-1) |
To merge this branch: | bzr merge lp:~rharding/launchpad/ec2_land_928853 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+92033@code.launchpad.net |
Commit message
[r=adeuring][bug=928853] Add check for None before removing None from the set of stakeholder emails.
Description of the change
= Summary =
Landing via ec2 land throws a keyerorr exception when it attempts to build the list of notification emails.
== Proposed Fix ==
The code there blindly runs a set.remove(None) when None might not be in the set. Per docs, that raises a keyerror. Add a check to see if None is in the set first, then remove if that's the case.
== Demo and Q/A ==
ec2 land should work
To post a comment you must log in.
Uhm, discard( None)
emails.
is the right way to do this :)