Merge lp:~rharding/launchpad/bugfix_723417 into lp:launchpad

[Richard Harding]

[r=gmb][bug=723417] Change default widget height of the DescriptionWidget to 15 vs the current 5.

= Issue Summary =
Moving to custom widget types removed the height setting on the field. The DescriptionWidget is used in this case and coded to 5 lines high.

== Proposed Fix ==
Change the height to 15 in the widget definition to improve the amount of visible space for entry.

== Pre-implementation Notes ==
It was brought up that it would be nice, especially in this case, to provide an auto expanding text widget. That idea and work is taking place over in: https://bugs.launchpad.net/launchpad/+bug/891735

== Tests ==
There are no direct tests for checking height and since it's a potential moving target, none were added.

== Q/A ==
Start a new bug, confirm none of the existing are what you want to submit and view that the "Further information" comment input is now 15 lines high

[Graham Binns (gmb)]

Works for me. This is one of those things that can only be tested by QA (and even then relies on the happiness of others; YMMV).

Approved, anway.

review: Approve (code)

=== modified file 'lib/lp/app/widgets/textwidgets.py'
--- lib/lp/app/widgets/textwidgets.py	2011-02-09 23:57:52 +0000
+++ lib/lp/app/widgets/textwidgets.py	2011-11-17 17:50:29 +0000
@@ -273,7 +273,7 @@
 class DescriptionWidget(TextAreaWidget):
     """A widget to capture a description."""
     width = 44
-    height = 5
+    height = 15
 
 
 class NoneableDescriptionWidget(DescriptionWidget):