Merge lp:~rharding/juju-gui/fix-watch-template-dirs into lp:juju-gui/experimental

Proposed by Richard Harding
Status: Needs review
Proposed branch: lp:~rharding/juju-gui/fix-watch-template-dirs
Merge into: lp:juju-gui/experimental
Diff against target: 12 lines (+1/-1)
1 file modified
lib/templates.js (+1/-1)
To merge this branch: bzr merge lp:~rharding/juju-gui/fix-watch-template-dirs
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+165187@code.launchpad.net

Description of the change

TRIVIAL: watch the correct var to build templates

- We noticed that the subapp template changes weren't causing auto reload.
Turns out there's a typo in there.

https://codereview.appspot.com/9653043/

To post a comment you must log in.
Revision history for this message
Richard Harding (rharding) wrote :

Reviewers: mp+165187_code.launchpad.net,

Message:
Please take a look.

Description:
TRIVIAL: watch the correct var to build templates

- We noticed that the subapp template changes weren't causing auto
reload.
Turns out there's a typo in there.

https://code.launchpad.net/~rharding/juju-gui/fix-watch-template-dirs/+merge/165187

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/9653043/

Affected files:
   A [revision details]
   M lib/templates.js

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: lib/templates.js
=== modified file 'lib/templates.js'
--- lib/templates.js 2013-05-17 14:51:05 +0000
+++ lib/templates.js 2013-05-22 15:16:39 +0000
@@ -205,7 +205,7 @@

  // When application specific templates change regen
  function watchTemplates(cb) {
- Y.Array.each(config.server.templates_dirs, function(dir) {
+ Y.Array.each(config.server.template_dirs, function(dir) {
      fs.watch(dir, function(event, filename) {
        //on dir change regen the cache
        ifValidFile(path.join(dir, filename), function() {

Revision history for this message
Richard Harding (rharding) wrote :

LGTM self-reviewing the one letter fix ftw

https://codereview.appspot.com/9653043/

Unmerged revisions

679. By Richard Harding

Fix a typo is watching the wrong dirs for template changes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/templates.js'
2--- lib/templates.js 2013-05-17 14:51:05 +0000
3+++ lib/templates.js 2013-05-22 15:52:28 +0000
4@@ -205,7 +205,7 @@
5
6 // When application specific templates change regen
7 function watchTemplates(cb) {
8- Y.Array.each(config.server.templates_dirs, function(dir) {
9+ Y.Array.each(config.server.template_dirs, function(dir) {
10 fs.watch(dir, function(event, filename) {
11 //on dir change regen the cache
12 ifValidFile(path.join(dir, filename), function() {

Subscribers

People subscribed via source and target branches