lp:~rharding/juju-gui/charm-details-1172050

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 607

Juju GUI Hackers: Pending requested 2013-04-24

Diff: 369 lines (+182/-18)

6 files modified

app/subapps/browser/browser.js (+46/-9)
app/subapps/browser/views/editorial.js (+4/-7)
app/subapps/browser/views/search.js (+48/-0)
test/test_browser_app.js (+60/-0)
test/test_browser_editorial.js (+0/-2)
test/test_browser_search_view.js (+24/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1172050: selecting a charm from the fullscreen search results doesn't swap to fullscren viewing of details

High

Fix Released

Link a bug report

Related blueprints

607. By Richard Harding on 2013-04-24

Fix the tests for the cases around search dispatch

606. By Richard Harding on 2013-04-24

Add test that query string is in the state and checked

605. By Richard Harding on 2013-04-24

Add failing test to start the day

604. By Richard Harding on 2013-04-24

lint

603. By Richard Harding on 2013-04-24

Work on getting the various multi-dispatches out of the way. Click handlers vs a links and such

602. By Richard Harding on 2013-04-23

Fixes #1171538 and #1171880

- Dislpay the first 10 charms in each container on fullscreen view
- Clicks on charms from fullscreen open the fullscreen charm details
- Drive by: remove the link to the test file that no longer exists
- Update the svg code to work since the juju-gui svg was trying hard to show
up now.
- Add tests for the editorial code. Not sure how I didn't have those before.
- Remove sidebar-editorial json file no longer needed. Outdated api
- Added the interesting.json for the updated api calls for testing

R=curtis, jeff.pihach
CC=
https://codereview.appspot.com/8923044

601. By Brad Crittenden on 2013-04-23

Use textarea for charm config entries.

If a charm config default value has multiple lines, then use a textarea box
for the entry in the charm config panel.

The textarea has some known styling issues when a scrollbar is automatically
shown. Given the infrequency of this styling being shown it has been OK'd for
landing with these visual deficiencies.

R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/8922043

600. By Richard Harding on 2013-04-23

Fixes #1167514 and #1171529 charm token display

- Hack the charm-token widget to not use the BrowserCharm.id to set the node's
ID attribute. There's no promise that the tokens are unique on a page of
display.
- Update the editorial to set the active CSS on selected charms.
- Update the subapp to make sure the editorial is rendered with a currently
selected charm if the url is actually a /sidebar/charm/id state.

R=jeff.pihach, j.c.sackett
CC=
https://codereview.appspot.com/8920043

599. By Richard Harding on 2013-04-23

Fix back button, hooks select, font sizes in tabs

Fix bugs per UX review.

- Fixes #1171500 - back button styling
- Fixes #1171522: Hooks - drop down list - show "Select --" as default. Remove
text below control.
- Fixes #1171524: Change in font size when select a tab

R=curtis
CC=
https://codereview.appspot.com/8825044

598. By j.c.sackett on 2013-04-23

Adds search functionality

This adds text search from the search widget
-Search widget propogates search text to browser subapp
-Subapp routes data to search view
-Search view does query from text
-Search view can render search results

As a driveby, this moves repeated apiFailure code out to an extension.

There is an issue outstanding:
-The querystring can be eaten by the routing code in some cases. A follow up
branch is in progress for this problem.

R=rharding, jeff.pihach, curtis
CC=
https://codereview.appspot.com/8910043