lp:~rharding/juju-gui/animation1

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:juju-gui/experimental

Juju GUI Hackers: Pending requested 2013-07-31

Diff: 334 lines (+147/-71)

9 files modified

app/subapps/browser/browser.js (+3/-3)
app/subapps/browser/templates/fullscreen.handlebars (+0/-1)
app/subapps/browser/templates/minimized.handlebars (+1/-1)
app/subapps/browser/templates/sidebar.handlebars (+1/-1)
app/subapps/browser/views/charm.js (+15/-7)
app/subapps/browser/views/view.js (+17/-7)
lib/views/browser/browser-icon.less (+33/-5)
lib/views/browser/main.less (+73/-46)
lib/views/browser/minimized.less (+4/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

917. By Richard Harding on 2013-07-31

Update to catch the details on close as well

916. By Richard Harding on 2013-07-31

More work on getting charm details to work right

915. By Richard Harding on 2013-07-31

Work on adjusting the css/html to allow for the sidebar/tab animations

914. By Jeff Pihach on 2013-07-31

Impl destroy ghost and service

This adds the destroy ghost and destroy service functionality
to match the V11 mockups. I took some engineer-license and
implemented a confirmation dialogue as well.

R=benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/12050049

913. By j.c.sackett on 2013-07-30

Removes charm store from fakebackend

-Rewrote the backend to use the API store to query for the charm.
-Updated model to provide the storeId in charmParts instead of the no longer
needed charm_store_path
-Updated model to set requires/provides from the API relations data.
-Added api-response json files for tests
-Provided new cached_charms in tests using new API data, and created new
FakeBackend (without charmstore)
-Updated tests, including using actual charm IDs; the old ones only worked
because the test processing ignored id validation.
-Drive bys.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/12115043

912. By Kapil Thangavelu on 2013-07-30

Fix boolean export from gui.

This updates the js-yaml with a fix for escaping string values which are yaml
1.1 aliases for booleans. By default js-yaml implements 1.2 which does away with
these aliases, resulting in roundtripping issues between gui and python or golang.

R=teknico, benji, gary.poster
CC=
https://codereview.appspot.com/11966044

911. By Madison Scott-Clary on 2013-07-30

Normalize window.flags in tests

window.flags now works just as it does in the app: it is set in test/index.html to an empty object (since the tests don't have the :flags: ns), and each test or each feature (usually divided up into suites, as they should be) deals solely with that feature flag only. If flags are set in a 'before', only those flags are unset in 'after', etc. This is as much a policy proposal as a branch, and I've created a weekly card to discuss.

R=gary.poster, rharding
CC=
https://codereview.appspot.com/12060044

910. By Jeff Pihach on 2013-07-30

Remove additional buttons on ghost insp.

Removes the additional buttons on the ghost inspector that
was caused by sharing the same template for the ghost and
service inspector configuration. The UI's differ between
these two inspectors, the ghost has the confirm/cancel buttons
fixed to the bottom of the inspector where the service
inspector has it fixed to the bottom of the settings list.
Maybe design will normalize these later?

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/12071043

909. By Huw Wilkins on 2013-07-30

Style inspector unit details panel

Styled the content on the inspector unit details. No reference designs so styled to look like content on the browser charm details and an old wireframe.

To see the panel add a charm to the canvas. Click on the service block. In the inspector open one of the headings under Units and click on the name of a unit. The panel will open to the left.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/12085043

908. By Richard Harding on 2013-07-30

Fixes #1202636 use pretty names for providers.

- The test data we import is run on HP cloud but named 'openstack'.
- We use the filter UI rules for translating the 'id' of a provider to a
pretty name.
- Those are updated so that an id of openstack will output HP Cloud since
that's what it actually is in testing.
- A work item has been brought up with the charmers team to correct the naming
to be 100% specific and updates will be coordinated at a later time.
- This means there are three tests and only three providers to display in the
gui: ec2, local, hp
- We add a template helper so that we can share the mapping of id -> pretty
name across all of the UI from filters through to the charm details page.

R=bac, gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/12102043