Merge ~rharding/interface-grafana-source:add-mysql-support into interface-grafana-source:master
Proposed by
Richard Harding
Status: | Merged |
---|---|
Merged at revision: | 402c7eda9fedfcfd83ef88e583e1819c58718293 |
Proposed branch: | ~rharding/interface-grafana-source:add-mysql-support |
Merge into: | interface-grafana-source:master |
Diff against target: |
77 lines (+40/-2) 2 files modified
provides.py (+37/-2) requires.py (+3/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jacek Nykis (community) | Needs Fixing | ||
Thomas Cuthbert (community) | Needs Fixing | ||
Review via email: mp+330041@code.launchpad.net |
Description of the change
Add support for mysql as a datasource in the interface.
Make sure it's backward compatible as much as possible.
- takes an optional database argument
- makes sure that the username/password is set
- supports ip:port for the url in the mysql case
To post a comment you must log in.
To support this I've pushed up my built grafana charm with the interface and tested it via:
juju deploy mysql; juju deploy cs:~rharding/ gypsy-danger- 3; juju deploy cs:~rharding/ grafana- 1 grafana- source grafana
juju relate mysql:db gypsy-danger; juju relate gypsy-danger:
juju expose grafana
And validated I can pull up the list of datasources and successfully "Save and test" the mysql datasource that's added.
Then I made sure it didn't regress promtheus by doing:
juju deploy prometheus; juju relate prometheus: grafana- source grafana
And again validating the data sources.