lp:~rharding/charmworld/support-implicit-relations

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:charmworld at revision 453

Juju Gui Bot: Approve (continuous-integration) on 2013-11-08

Charmworld Developers: Pending requested 2013-11-08

Diff: 53 lines (+35/-0)

2 files modified

charmworld/lib/proof.py (+9/-0)
charmworld/lib/tests/test_proof.py (+26/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

453. By Richard Harding on 2013-11-08

Add support for implicit juju- relations

452. By Richard Harding on 2013-11-08

Update proof to handle 0 rev charms.

- When parsing the store url for a rev the regex would return the int 0
- Proof checks to determine if a revision was defined would use if revision
and fail (bool(0) == False)
- Updates the if checks to use if revision is not None, if revision is None
directly.

https://codereview.appspot.com/23600043/

R=bac.

Approved by Juju Gui Bot.

451. By j.c.sackett on 2013-11-08

Removes old-revision proof error charms from the review queue. Fixes: https://bugs.launchpad.net/bugs/1247891.

Approved by Juju Gui Bot, Curtis Hovey.

450. By Brad Crittenden on 2013-11-07

Use forked charm-tools to allow tweaking endpoint.

- The download-cache is updated with the forked build
- Tweaks to force ingest to look at localhost:port to run
- Added the port to the config and updated the production overrides so that
production talks to itself without egress filter issues.
- Update tests for the extra kwarg endpoint.

Note: You cannot ingest bundles without a running instance. This means
to ingest bundles in local dev you must also `make run`.

https://codereview.appspot.com/22540043/

R=bac.

Approved by Juju Gui Bot.

449. By Richard Harding on 2013-11-07

I'm sick of hitting refresh to watch the queue.

https://codereview.appspot.com/22600043/

R=.

Approved by Juju Gui Bot.

448. By Brad Crittenden on 2013-11-06

Add tests for short_url routing.

https://codereview.appspot.com/21930046/

R=rharding.

Approved by Juju Gui Bot.

447. By Richard Harding on 2013-11-06

Support float config type in proof.

- if we don't support validating it then ignore it for now
- add tests to each type we validate.

https://codereview.appspot.com/22370044/

R=bac.

Approved by Juju Gui Bot.

446. By Brad Crittenden on 2013-11-06

Fix the bundle short_url.

The search results page uses the short_url so clicking on results
gives a 404 without this change.

https://codereview.appspot.com/22360043/

R=bac.

Approved by Juju Gui Bot.

445. By Brad Crittenden on 2013-11-06

Fix 021 migration

https://codereview.appspot.com/22260044/

R=bac.

Approved by Juju Gui Bot.

444. By Brad Crittenden on 2013-11-06

Bundle proofing plus migration.

Bundles are only rejected if there are errors not just warnings.
A migration script is provided that will remove all existing bundles. The
good bundles will later be repopulated when ingest runs again.

https://codereview.appspot.com/21790045/

R=gary, sinzui.

Approved by Juju Gui Bot.