Merge lp:~rharding/charmworld/apply-cowboys into lp:charmworld
Proposed by
Richard Harding
Status: | Merged |
---|---|
Approved by: | Richard Harding |
Approved revision: | 490 |
Merged at revision: | 494 |
Proposed branch: | lp:~rharding/charmworld/apply-cowboys |
Merge into: | lp:charmworld |
Diff against target: |
114 lines (+11/-24) 4 files modified
charmworld/search.py (+8/-11) charmworld/tests/test_search.py (+0/-9) charmworld/views/api/__init__.py (+1/-3) charmworld/views/search.py (+2/-1) |
To merge this branch: | bzr merge lp:~rharding/charmworld/apply-cowboys |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Gui Bot | continuous-integration | Approve | |
Richard Harding | Approve | ||
Benji York (community) | code | Approve | |
Review via email: mp+211517@code.launchpad.net |
Commit message
Update scoring to be limited on ES side.
- Drive-by to make sure we log the exception from ES for debugging purposes.
Description of the change
Update scoring to be limited on ES side.
- Drive-by to make sure we log the exception from ES for debugging purposes.
To post a comment you must log in.
There is a nice alternative to log.error(str(exc)) in the logging
package: log.exception()
If the logging is important, we should have tests to ensure it keeps
working.
If the default value for min_score were set to MIN_ES_SCORE then we
wouldn't need the inline-if expression to set if no value was provided.