There seems to be no default value set for seats, i.e. if you do:
$ cd tests
$ DEBUG=1 ./test-autologin
you get logs like:
[+0.00s] DEBUG: Seat (null): Creating user session
If the ID is NULL, id expect to see:
[+0.00s] DEBUG: Seat: Creating user session
or at least a valid ID.
You don't need to break at 80 characters, I've fixed the whitespace in this branch: lp:~robert-ancell/lightdm/multiseat-logging-whitespace
(I suggest you manually patch to keep the attribution to you for the changes).
Also, now the logging is better, we have some redundant text.
[+0.00s] DEBUG: Seat (null): Starting seat
should become
[+0.00s] DEBUG: Seat (null): Starting
Though I wont block this merge on this. We can fix this in a later MP if you like.
Nice work!
There seems to be no default value set for seats, i.e. if you do:
$ cd tests
$ DEBUG=1 ./test-autologin
you get logs like:
[+0.00s] DEBUG: Seat (null): Creating user session
If the ID is NULL, id expect to see:
[+0.00s] DEBUG: Seat: Creating user session
or at least a valid ID.
You don't need to break at 80 characters, I've fixed the whitespace in this branch:
lp:~robert-ancell/lightdm/multiseat-logging-whitespace
(I suggest you manually patch to keep the attribution to you for the changes).
Also, now the logging is better, we have some redundant text.
[+0.00s] DEBUG: Seat (null): Starting seat
should become
[+0.00s] DEBUG: Seat (null): Starting
Though I wont block this merge on this. We can fix this in a later MP if you like.