Code review comment for lp:~rexbron/bzr-builddeb/trunk.profiles

Revision history for this message
James Westby (james-w) wrote :


Thanks for working on this, apologies for the delay in reviewing it.

The change looks small and un-obtrusive, I just have a question about
the config file format. You went for

  profile-builder = "foo"

I think this should be

  builder = "foo"

However I was expecting

  revu = "foo"
  ppa = "bar"


Your way obviously allows us to define other things for a profile, but I am
struggling to think of what that might be. Do you have any examples?

Also, what do you think about case-sensitivity. I think the profile names should
be case-insensitive, but that is obviously not that easy to accomplish. How
important do you think that is?



review: Needs Fixing

« Back to merge proposal