Merge lp:~returntoreptar/curtin/removable-drive-fixes into lp:~curtin-dev/curtin/trunk
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 345 | ||||
Proposed branch: | lp:~returntoreptar/curtin/removable-drive-fixes | ||||
Merge into: | lp:~curtin-dev/curtin/trunk | ||||
Diff against target: |
22 lines (+12/-0) 1 file modified
curtin/commands/block_meta.py (+12/-0) |
||||
To merge this branch: | bzr merge lp:~returntoreptar/curtin/removable-drive-fixes | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Clark (community) | Approve on 2016-01-25 | ||
Review via email:
|
Description of the change
The past few months I have been having an issue with 5 or so of my machines which popped up due to an update to curtin. I have finally traced down the issue to a specific commit to the code (http://
The full error text encountered that is fixed by this commit is as follows:
list index out of range
Installation failed with exception: Unexpected error while running command.
Command: ['curtin', 'block-meta', 'simple']
Exit code: 3
Reason: -
Stdout: 'list index out of range\n'
Stderr: ''
This commit will also most likely help with https:/
For reference, the specific hardware that this error is happening on:
HP proliant DL100 g2
IBM system x3650 M1
An old server from PSSC labs
So this problem does not seem to be constrained to just 1 vendor.
Scott Moser (smoser) wrote : | # |
Robert Clark (returntoreptar) wrote : | # |
Thanks for the reply!
a.) Done, bug report filed here: https:/
b.) I tried this on trusty and wily, both failed with the exact same error, so it seems this is still an issue in the latest ubuntu releases.
Robert Clark (returntoreptar) wrote : | # |
Is there anything else I need to do to this merge request at this point or is it just waiting on additional review?
Dave Chiluk (chiluk) wrote : | # |
IIUC, I think Scott's point was that if it fails on the newer Ubuntu's then a bug needs to be opened against the upstream for lsblk as well, so that it correctly reports your drives as not removable.
Hey, this looks good.
2 questions, though
a.) can we file a bug on lsblk stating that your devices are not removable?
b.) did this fail to install precise? trusty? wily?
Just wondering to see if lsblk is fixed in newer ubuntu possibly.