Code review comment for lp:~rengolin/cbuild/llvm
Revision history for this message
| Matthew Gretton-Dann (matthew-gretton-dann) wrote | # |
review:
Approve
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
So this looks fine as is (its better than what is currently there).
A better way may be to use the GCCCONFARGS variable. This is set by the various build config Makefiles in cbuild/config (one for each queue type). This means that you can change the target build depending on which queue you use.
However, the GCCCONFARGS may not contain stuff that LLVM understands, so some rework of that or mangling of it may be necessary.
So this patch is an improvement on the current state (and so I'll approve it) - but there may be an even better way ahead.