Merge lp:~renatonlima/openerp-fiscal-rules/openerp-fiscal-rules-security-rule into lp:openerp-fiscal-rules

Proposed by Renato Lima - http://www.akretion.com on 2014-01-15
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp on 2014-02-21
Approved revision: 67
Merged at revision: 68
Proposed branch: lp:~renatonlima/openerp-fiscal-rules/openerp-fiscal-rules-security-rule
Merge into: lp:openerp-fiscal-rules
Diff against target: 17 lines (+7/-0)
1 file modified
account_fiscal_position_rule/security/account_fiscal_position_rule_security.xml (+7/-0)
To merge this branch: bzr merge lp:~renatonlima/openerp-fiscal-rules/openerp-fiscal-rules-security-rule
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve on 2014-02-21
Raphaël Valyi - http://www.akretion.com Approve on 2014-01-15
Pedro Manuel Baeza code review 2014-01-15 Approve on 2014-01-15
Review via email: mp+201765@code.launchpad.net

Description of the change

Hello Guys,

I added one security rule for object account.fiscal.position.rule to filter records by company and help configuration when you have more that one company and many fiscal position rule records

Best regards,

Renato Lima - http://www.akretion.com

To post a comment you must log in.
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)

LGTM; very useful

review: Approve

LGTM

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_fiscal_position_rule/security/account_fiscal_position_rule_security.xml'
2--- account_fiscal_position_rule/security/account_fiscal_position_rule_security.xml 2012-10-26 14:52:39 +0000
3+++ account_fiscal_position_rule/security/account_fiscal_position_rule_security.xml 2014-01-15 12:26:24 +0000
4@@ -3,6 +3,13 @@
5
6 <data>
7
8+ <record id="account_fiscal_position_rule_rule" model="ir.rule">
9+ <field name="name">Fiscal Position Rule</field>
10+ <field name="model_id" ref="model_account_fiscal_position_rule"/>
11+ <field name="global" eval="True"/>
12+ <field name="domain_force">['|',('company_id','=',False),('company_id','child_of',[user.company_id.id])]</field>
13+ </record>
14+
15 </data>
16
17 </openerp>