Merge lp:~renatofilho/unity8/green-led into lp:unity8

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Michael Zanetti
Approved revision: 1795
Merged at revision: 1794
Proposed branch: lp:~renatofilho/unity8/green-led
Merge into: lp:unity8
Diff against target: 23 lines (+8/-0)
1 file modified
qml/Panel/Indicators/IndicatorsLight.qml (+8/-0)
To merge this branch: bzr merge lp:~renatofilho/unity8/green-led
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Zanetti (community) Approve
Review via email: mp+260975@code.launchpad.net

Commit message

Set the device led color to green.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

see linked bug

 * Did you have a look at the warnings when running tests? Can they be reduced?

no new warnings

To post a comment you must log in.
lp:~renatofilho/unity8/green-led updated
1795. By Renato Araujo Oliveira Filho

Used "darkgreen" color insted of "UbuntuColors.green". Looks better on the led.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

waiting, but shouldn't affect anything

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Panel/Indicators/IndicatorsLight.qml'
2--- qml/Panel/Indicators/IndicatorsLight.qml 2014-11-11 10:45:41 +0000
3+++ qml/Panel/Indicators/IndicatorsLight.qml 2015-06-03 16:30:59 +0000
4@@ -26,6 +26,8 @@
5 QtObject {
6 id: root
7
8+ property color color: "darkgreen"
9+
10 property var _actionGroup: QMenuModel.QDBusActionGroup {
11 busType: 1
12 busName: "com.canonical.indicator.messages"
13@@ -50,4 +52,10 @@
14 return (Powerd.status === Powerd.Off && _rootState.hasMessages) ? Lights.On : Lights.Off
15 }
16 }
17+
18+ property var _colorBinding: Binding {
19+ target: Lights
20+ property: "color"
21+ value: root.color
22+ }
23 }

Subscribers

People subscribed via source and target branches