Unity8 Session Snap

Merge lp:~renatofilho/unity8-session-snap/fix-1646611 into lp:unity8-session-snap

  1. fix-1646611
  2. Merge into snap
Proposed by Renato Araujo Oliveira Filho
Status: Rejected
Rejected by: Renato Araujo Oliveira Filho
Proposed branch: lp:~renatofilho/unity8-session-snap/fix-1646611
Merge into: lp:unity8-session-snap
Diff against target: 11 lines (+1/-0)
1 file modified
overlay/snappyenv (+1/-0)
To merge this branch: bzr merge lp:~renatofilho/unity8-session-snap/fix-1646611
Reviewer Review Type Date Requested Status
Michael Terry (community) Needs Fixing
Review via email: mp+312863@code.launchpad.net

Commit message

Make sure that "XDG_DATA_HOME" is a writable directory.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

I think that this should be SNAP_USER_COMMON not the SNAP_DATA, that's the root area.

Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Or SNAP_USER_DATA if you still want it versioned.

Revision history for this message
Michael Terry (mterry) wrote :

As mentioned on IRC, XDG_DATA_HOME defaults to $HOME/.local/share and HOME=$SNAP_USER_COMMON for this snap. So this *shouldn't* be needed.

review: Needs Fixing

Unmerged revisions

97. By Renato Araujo Oliveira Filho

Make sure that "XDG_DATA_HOME" is a writable directory.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'overlay/snappyenv'
2--- overlay/snappyenv 2016-12-02 19:23:09 +0000
3+++ overlay/snappyenv 2016-12-08 20:54:02 +0000
4@@ -97,6 +97,7 @@
5 # XDG Config
6 export XDG_CONFIG_DIRS=$SNAP/xdg-config-dirs:$XDG_CONFIG_DIRS
7 export XDG_DATA_DIRS=$SNAP_DATA/xdg-data:$SNAP_COMMON/xdg-data:$SNAP/:$XDG_DATA_DIRS
8+export XDG_DATA_HOME=$SNAP_DATA/xdg-data-home
9
10 # work around crashes caused by appmenu-qt5
11 # https://bugs.launchpad.net/appmenu-qt5/+bug/1606246

Subscribers

People subscribed via source and target branches