ubuntuone-credentials

Merge lp:~renatofilho/ubuntuone-credentials/fix-tests into lp:ubuntuone-credentials

  1. fix-tests
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho on 2016-08-04
Status: Rejected
Rejected by: dobey on 2016-08-04
Proposed branch: lp:~renatofilho/ubuntuone-credentials/fix-tests
Merge into: lp:ubuntuone-credentials
Diff against target: 10 lines (+3/-0)
1 file modified
debian/rules (+3/-0)
To merge this branch: bzr merge lp:~renatofilho/ubuntuone-credentials/fix-tests
Reviewer Review Type Date Requested Status
dobey (community) 2016-08-04 Disapprove on 2016-08-04
unity-api-1-bot continuous-integration Approve on 2016-08-04
Review via email: mp+302015@code.launchpad.net

Commit Message

Does not run test on parallel.

To post a comment you must log in.
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:248
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntuone-credentials-ci/9/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/279
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/285
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/219
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/219
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/219
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/148
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/148/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/148
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/148/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/148
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/148/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/148
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/148/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/148
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/148/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/148
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/148/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/148
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/148/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/148
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/148/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/148
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/148/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntuone-credentials-ci/9/rebuild

review: Approve (continuous-integration)
dobey (dobey) wrote :

This doesn't change anything with the tests themselves. It simply makes them not run. The tests are not being run with ctest. And the failures are all in a single test, so disabling parallel builds for the tests won't change anything either.

review: Disapprove

Unmerged revisions

248. By Renato Araujo Oliveira Filho on 2016-08-04

Does not run test on parallel.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/rules'
2--- debian/rules 2016-03-23 19:29:45 +0000
3+++ debian/rules 2016-08-04 12:07:48 +0000
4@@ -15,3 +15,6 @@
5
6 override_dh_auto_configure:
7 dh_auto_configure -- -DLIB_SUFFIX=/$(DEB_HOST_MULTIARCH)
8+
9+override_dh_auto_test:
10+ ctest -j1 --output-on-failure

Subscribers

People subscribed via source and target branches