Merge lp:~renatofilho/ubuntu-ui-toolkit/fix-keyboard-visibility into lp:ubuntu-ui-toolkit

[Renato Araujo Oliveira Filho]

Make sure that the keyboard does not obscure the contents of main window.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:626
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/338/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1061/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/195/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/195/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1065/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/338/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:627
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/339/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1062/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/196/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/196/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1066/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/339/rebuild

review: Needs Fixing (continuous-integration)

[Florian Boucault (fboucault)]

Add a FIXME next to "Behavior on bottomMargin" saying that it's not well synchronised with the keyboard's animation and why.

review: Needs Fixing

[Florian Boucault (fboucault)]

// make the hole contents visible is the toolbar is locked otherwise the toolbar will obscure part of the contents

should be:

// move the whole contents up if the toolbar is locked and opened otherwise the toolbar will obscure part of the contents

review: Needs Fixing

[Florian Boucault (fboucault)]

 The property holds if the application should automaticaly resize the [...]

should be

 The property holds if the application should automatically resize the [...]

[Florian Boucault (fboucault)]

Thanks for adding the line to CHANGES. We also have an automatic API checker that outputs components.api and components.api.new when running make check. They need to be in sync otherwise the tests fail.

review: Needs Fixing

[Florian Boucault (fboucault)]

Documentation of anchorToKeyboard needs to specify what the default value is.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:629
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/340/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1063/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/197/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/197/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1067/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/340/rebuild

review: Needs Fixing (continuous-integration)

[Florian Boucault (fboucault)]

> Thanks for adding the line to CHANGES. We also have an automatic API checker
> that outputs components.api and components.api.new when running make check.
> They need to be in sync otherwise the tests fail.

See test failure output:

--- components.api 2013-07-12 22:47:31.000000000 +0000
+++ components.api.new 2013-07-12 22:50:59.189958961 +0000
@@ -81,6 +81,7 @@ modules/Ubuntu/Components/Label.qml
 modules/Ubuntu/Components/MainView.qml
 PageTreeNode
     property string applicationName
+ property bool anchorToKeyboard
     property color headerColor
     property color backgroundColor
     property color footerColor

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:633
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/341/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1064
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/198
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/198
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/198/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1068
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1068/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/909

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/341/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-autolanding/153/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1159
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-autolanding/79
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-autolanding/79/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1163
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1163/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/989

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'CHANGES'
--- CHANGES	2013-07-01 19:05:06 +0000
+++ CHANGES	2013-07-13 00:02:26 +0000
@@ -39,6 +39,7 @@
 * DEPRECATED IN Action: property bool visible
 * DEPRECATED IN Action: property Item itemHint
 * DEPRECATED: ToolbarActions component (use ToolbarItems instead)
+* ADDED IN MainView: property bool anchorToKeyboard
 
 Compatibility Breaks
 ********************

=== modified file 'components.api'
--- components.api	2013-07-12 05:22:28 +0000
+++ components.api	2013-07-13 00:02:26 +0000
@@ -81,6 +81,7 @@
 modules/Ubuntu/Components/MainView.qml
 PageTreeNode
     property string applicationName
+    property bool anchorToKeyboard
     property color headerColor
     property color backgroundColor
     property color footerColor

=== modified file 'modules/Ubuntu/Components/MainView.qml'
--- modules/Ubuntu/Components/MainView.qml	2013-07-12 05:32:25 +0000
+++ modules/Ubuntu/Components/MainView.qml	2013-07-13 00:02:26 +0000
@@ -136,6 +136,15 @@
     property string applicationName: ""
 
     /*!
+      \preliminary
+      The property holds if the application should automatically resize the
+      contents when the input method appears
+
+      The default value is false.
+      */
+    property bool anchorToKeyboard: false
+
+    /*!
       \qmlproperty color headerColor
       Color of the header's background.
 
@@ -214,6 +223,15 @@
         id: canvas
 
         automaticOrientation: false
+        // this will make sure that the keyboard does not obscure the contents
+        anchors {
+            bottomMargin: Qt.inputMethod.visible && anchorToKeyboard ? Qt.inputMethod.keyboardRectangle.height : 0
+            //this is an attempt to keep the keyboard animation in sync with the content resize
+            //but this does not work very well because the keyboard animation has different steps
+            Behavior on bottomMargin {
+                NumberAnimation { easing.type: Easing.InOutQuad }
+            }
+        }
 
         // clip the contents so that it does not overlap the header
         Item {
@@ -234,6 +252,9 @@
                 id: contents
                 anchors {
                     fill: parent
+                    
+                    // move the whole contents up if the toolbar is locked and opened otherwise the toolbar will obscure part of the contents
+                    bottomMargin: toolbarItem.locked && toolbarItem.opened ? toolbarItem.height + toolbarItem.triggerSize : 0
                     // compensate so that the actual y is always 0
                     topMargin: -parent.y
                 }