Merge lp:~renatofilho/ubuntu-system-settings/symbolic-icon into lp:ubuntu-system-settings

[Renato Araujo Oliveira Filho]

Added a symbolic icon to be used on messaging-menu.

Added a symbolic icon to be used on messaging-menu.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1358
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/2032/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1975
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/302
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1742
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1973
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1973/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19168

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/2032/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1358
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/2037/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2020
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/307
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1781
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2018
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2018/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19249

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/2037/rebuild

review: Approve (continuous-integration)

[Sebastien Bacher (seb128)]

Thanks, do we have writen design guidelines about that? Also is it common to ship the icon with the software rather than with the theme?

review: Needs Information

[Renato Araujo Oliveira Filho (renatofilho)]

> Thanks, do we have writen design guidelines about that? Also is it common to
> ship the icon with the software rather than with the theme?

Yes the original designer was to use the symbolic icon. But since some changes on application packaging (Trying to become a more self contained app "click-app") the icon got broken.

The idea is to have all apps as click app in the future (I am not sure if it still valid), in way to do that the app should ship his own icon. This app is already shipping the original icon but the symbolic icon was missing.

[Sebastien Bacher (seb128)]

do you have a reference to the design/recommendation? I guess settings is not the only concerned and it would be good to have public guidelines...

[Renato Araujo Oliveira Filho (renatofilho)]

I did not find any document about that. I remember to have one a long time ago when I was working on that but the designers that are working with me left canonical already;

What I can say is that: This was working before change the application name to the full icon path. You can confirm that by just using the icon name instead of the full path icon. It will "atomagically" find the symbolic icon and use that on the messaging menu (there is no need to explicitly specify the symbolic icon name when you use the only the icon name).
But as I said before this new property X-Ubuntu-SymbolicIcon was created to cover click app use case, and since system settings is using the full icon name it must specify the symbolic-icon-name.

And yes this is valid for all Apps that use the full icon name on desktop file.

[Sebastien Bacher (seb128)]

That new .desktop key seems buggy, we should just try to load <Icon>-symbolic and fallback if it's not available... the change looks fine to me otherwise, the current system seems bogus though (but maybe this merge proposal is not the place to discuss that)

[Sebastien Bacher (seb128)]

discussed with Ted on IRC, that seems suboptimal to me but seems like it's the way it is for format reasons, so let's say it's ok

review: Approve

[Matthew Paul Thomas (mpt)]

There is nothing in the spec that says the icon should be different from normal; it just says "Application icon to identify where the message has come from". <http://goo.gl/KIrWzF> We couldn't reasonably expect every app that might appear in the Notifications list to package a symbolic version of its own icon. And even if they did, it wouldn't be a good idea, because it would be harder to distinguish apps in the list.

review: Disapprove (design)

[Sebastien Bacher (seb128)]

rejecting based on design feedback from mpt, see previous comment

Unmerged revisions

1358. By Renato Araujo Oliveira Filho on 2015-03-25

Added a symbolic icon to be used on messaging-menu.

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2014-11-19 18:05:48 +0000
+++ CMakeLists.txt	2015-03-25 19:25:45 +0000
@@ -87,9 +87,13 @@
 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}
         DESTINATION ${CMAKE_INSTALL_DATADIR}/applications)
 
+set(APP_ICONS
+    system-settings.png
+    system-settings-symbolic.png
+)
 install(FILES ubuntu-system-settings.url-dispatcher DESTINATION share/url-dispatcher/urls)
 install(FILES screenshot.png DESTINATION ${SETTINGS_SHARE_DIR})
-install(FILES system-settings.png DESTINATION ${SETTINGS_SHARE_DIR})
+install(FILES ${APP_ICONS} DESTINATION ${SETTINGS_SHARE_DIR})
 install(PROGRAMS push-helper/software_updates_helper.py DESTINATION ${PUSH_HELPER_DIR} RENAME ubuntu-system-settings)
 
 if(cmake_build_type_lower MATCHES coverage)

=== added file 'system-settings-symbolic.png'
Binary files system-settings-symbolic.png	1970-01-01 00:00:00 +0000 and system-settings-symbolic.png	2015-03-25 19:25:45 +0000 differ
=== modified file 'ubuntu-system-settings.desktop.in.in'
--- ubuntu-system-settings.desktop.in.in	2014-10-01 14:10:47 +0000
+++ ubuntu-system-settings.desktop.in.in	2015-03-25 19:25:45 +0000
@@ -14,3 +14,4 @@
 X-Ubuntu-Single-Instance=true
 X-Ubuntu-Default-Department-ID=accessories
 X-Ubuntu-Splash-Show-Header=true
+X-Ubuntu-SymbolicIcon=@SETTINGS_SHARE_DIR@/system-settings-symbolic.png