Merge lp:~renatofilho/ubuntu-filemanager-app/ubuntu-app-platform into lp:ubuntu-filemanager-app

Proposed by Renato Araujo Oliveira Filho on 2016-11-18
Status: Merged
Approved by: Carlos Jose Mazieri on 2016-11-20
Approved revision: 580
Merged at revision: 579
Proposed branch: lp:~renatofilho/ubuntu-filemanager-app/ubuntu-app-platform
Merge into: lp:ubuntu-filemanager-app
Diff against target: 50 lines (+10/-11)
1 file modified
snapcraft.yaml (+10/-11)
To merge this branch: bzr merge lp:~renatofilho/ubuntu-filemanager-app/ubuntu-app-platform
Reviewer Review Type Date Requested Status
Carlos Jose Mazieri 2016-11-18 Approve on 2016-11-20
Jenkins Bot continuous-integration Approve on 2016-11-18
Review via email: mp+311318@code.launchpad.net

Commit message

Use 'ubuntu-app-platform' plugin.

To post a comment you must log in.
580. By Renato Araujo Oliveira Filho on 2016-11-18

Added default provider for ubuntu-app-platform.

review: Approve (continuous-integration)

Hello Renato,

I am sorry for my lack of knowledge about this,

     Can you explain what is it for?

     What does it improve the app?

     Is it required for others/all core apps?

     What is/does ubuntu-app-plataform plugin?

review: Needs Information

Hi Carlos

> Can you explain what is it for?
> What does it improve the app?
> Is it required for others/all core apps?
> What is/does ubuntu-app-plataform plugin?

The current snap package for this app pack all deps in the packages making the package with about 100MB. This change will make use of 'ubuntu-app-platform' snappy which is a content share interfaces that share the ubuntu platform shared libraries with the app avoiding the need to packa it with the app.

Renato,

Thanks for the information, that is OK.

review: Approve

> Renato,
>
> Thanks for the information, that is OK.

@carlos, could you top approval it?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'snap'
2=== added directory 'snap/ubuntu-app-platform'
3=== renamed file 'ubuntu-filemanager-app.wrapper' => 'snap/ubuntu-filemanager-app.wrapper'
4=== modified file 'snapcraft.yaml'
5--- snapcraft.yaml 2016-10-10 14:45:10 +0000
6+++ snapcraft.yaml 2016-11-18 23:37:28 +0000
7@@ -8,7 +8,14 @@
8 apps:
9 ubuntu-filemanager-app:
10 command: desktop-launch $SNAP/bin/ubuntu-filemanager-app --desktop_file_hint=unity8 "$@"
11- plugs: [unity7, opengl, home]
12+ plugs: [unity7, opengl, home, platform]
13+
14+plugs:
15+ platform:
16+ interface: content
17+ content: ubuntu-app-platform1
18+ target: ubuntu-app-platform
19+ default-provider: ubuntu-app-platform
20
21 parts:
22 ubuntu-filemanager-app:
23@@ -30,25 +37,17 @@
24 - libsmbclient-dev
25
26 stage-packages:
27- - qtdeclarative5-qtquick2-plugin
28- - qtdeclarative5-u1db1.0
29- - qml-module-ubuntu-components
30- - qtdeclarative5-ubuntu-content1
31 - libsmbclient
32- - qtubuntu-desktop
33- - suru-icon-theme
34- - mir-graphics-drivers-desktop
35- - humanity-icon-theme
36
37 snap:
38 - -usr/lib/python3
39 - -usr/share/doc
40 - -usr/include
41
42- after: [desktop-qt5]
43+ after: [desktop-ubuntu-app-platform]
44
45 environment:
46- source: .
47+ source: snap/
48 plugin: dump
49 organize:
50 ubuntu-filemanager-app.wrapper: bin/ubuntu-filemanager-app

Subscribers

People subscribed via source and target branches